You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by roxanne chang <ro...@trend.com.tw> on 2013/03/11 03:28:55 UTC

Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM already done in SecondarySotrageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Prasanna Santhanam <ts...@apache.org>.

> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote:
> > This is a old patch, is it still valid ?

Hmm - quite embarrassing it is over 3 months old. We may have missed a contributor :(

However should be valid still because the secondary storage host still shows 'Alert' on all installs. 


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review21971
-----------------------------------------------------------


On May 31, 2013, 1:01 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 1:01 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and edison su.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
>   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Nitin Mehta <Ni...@citrix.com>.
Roxanne/Abhi - Thanks for following up. I guess this should be resolved by
the Object Store work going on.
Edison/Min - Would we still be having an entry for the secondary storage
in the host table ?

Thanks,
-Nitin

On 17/06/13 12:01 PM, "Abhinandan Prateek" <ap...@apache.org> wrote:

>
>
>> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote:
>> > This is a old patch, is it still valid ?
>> 
>> Prasanna Santhanam wrote:
>>     Hmm - quite embarrassing it is over 3 months old. We may have
>>missed a contributor :(
>>     
>>     However should be valid still because the secondary storage host
>>still shows 'Alert' on all installs.
>> 
>> roxanne chang wrote:
>>     It will be nice if the changes can help. And.. Is the new design
>>finished ?
>
>Roxanne,  you may have to redo the patch on the current master and
>resubmit as it fails to apply now.
>
>
>- Abhinandan
>
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9818/#review21971
>-----------------------------------------------------------
>
>
>On May 31, 2013, 1:01 a.m., roxanne chang wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9818/
>> -----------------------------------------------------------
>> 
>> (Updated May 31, 2013, 1:01 a.m.)
>> 
>> 
>> Review request for cloudstack, Abhinandan Prateek and edison su.
>> 
>> 
>> Description
>> -------
>> 
>> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert
>>status
>> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
>> 
>> In file SecondarySotrageManagerImpl.java, function
>>generateSetupCommand, if the host type is Secondary storage VM, the
>>logic is to set secondarystorage host, at this time, secondarystorage
>>host stauts should become Up.
>> 
>> The secondary storage host always remains Alert status, because before
>>the secondary storage vm is deployed, the secondary storage host is
>>created. The tricky way (in the end of file AgentManagerImpl.java,
>>function NotifiMonitorsOfConnection) will try to disconnect secondary
>>storage, therefore the secondary storage host becomes Alert status. The
>>code should take SSVM into consider, not only Answer reponse.
>> 
>> File ResourceManagerImpl.java, function discoverHostsFull, in the end
>>will call discoverer.postDiscovery, in file
>>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is
>>not needed since its use to make secondary storage host wait for SSVM is
>>already done in SecondaryStorageManagerImpl. This makes why secondary
>>storage host always remains Alert status.
>> 
>> 
>> This addresses bug
>>https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
>> 
>> 
>> Diffs
>> -----
>> 
>>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58
>>   
>>server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java
>>3ca74a3 
>>   
>>server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
>>46ac7af 
>> 
>> Diff: https://reviews.apache.org/r/9818/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> Test 4.0.0, 4.2.0 in basic mode, works well.
>> 
>> 
>> Thanks,
>> 
>> roxanne chang
>> 
>>
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Abhinandan Prateek <ap...@apache.org>.

> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote:
> > This is a old patch, is it still valid ?
> 
> Prasanna Santhanam wrote:
>     Hmm - quite embarrassing it is over 3 months old. We may have missed a contributor :(
>     
>     However should be valid still because the secondary storage host still shows 'Alert' on all installs.
> 
> roxanne chang wrote:
>     It will be nice if the changes can help. And.. Is the new design finished ?

Roxanne,  you may have to redo the patch on the current master and resubmit as it fails to apply now.


- Abhinandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review21971
-----------------------------------------------------------


On May 31, 2013, 1:01 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 1:01 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and edison su.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
>   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.

> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote:
> > This is a old patch, is it still valid ?
> 
> Prasanna Santhanam wrote:
>     Hmm - quite embarrassing it is over 3 months old. We may have missed a contributor :(
>     
>     However should be valid still because the secondary storage host still shows 'Alert' on all installs.

It will be nice if the changes can help. And.. Is the new design finished ?


- roxanne


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review21971
-----------------------------------------------------------


On May 31, 2013, 1:01 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 1:01 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and edison su.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
>   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review21971
-----------------------------------------------------------


This is a old patch, is it still valid ?

- Abhinandan Prateek


On May 31, 2013, 1:01 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 1:01 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and edison su.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
>   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review22206
-----------------------------------------------------------


NFS secondary storage is not stored in host table any more. Yes, finally, it's been removed.

- edison su


On June 19, 2013, 6:50 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6:50 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and edison su.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java c343286 
>   services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java d3af792 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request 9818: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review22578
-----------------------------------------------------------


Roxanne, thanks for working on the patch and resubmitting!
Since the storage subsystem has been revamped the secondary storage does not show in Alert state anymore, I will mark this patch as discarded for now.

- Prasanna Santhanam


On June 19, 2013, 6:50 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6:50 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-1594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java c343286 
>   services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java d3af792 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated June 19, 2013, 6:50 a.m.)


Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and edison su.


Changes
-------

add Nitin


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java c343286 
  services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java d3af792 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated June 19, 2013, 6:45 a.m.)


Review request for cloudstack, Abhinandan Prateek and edison su.


Changes
-------

update.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs (updated)
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java c343286 
  services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java d3af792 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated June 19, 2013, 6:42 a.m.)


Review request for cloudstack, Abhinandan Prateek and edison su.


Changes
-------

new patch to solve Secondary storage host always remains Alert status.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Animesh Chaturvedi <An...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated May 31, 2013, 1:01 a.m.)


Review request for cloudstack, Abhinandan Prateek and edison su.


Changes
-------

Adding Abhi as reviewer


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

RE: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Animesh Chaturvedi <an...@citrix.com>.
Edison

Please review and apply patch if satisfied

Animesh

From: roxanne chang [mailto:noreply@reviews.apache.org] On Behalf Of roxanne chang
Sent: Wednesday, March 13, 2013 8:26 PM
To: Edison Su
Cc: cloudstack; Animesh Chaturvedi; roxanne chang
Subject: Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/


Review request for cloudstack and edison su.
By roxanne chang.

Updated March 14, 2013, 3:25 a.m.

Changes

Add Edison Su as reviewers.


Description (updated)

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]



In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.



The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.



File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


Testing

Test 4.0.0, 4.2.0 in basic mode, works well.

Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-1594
Diffs

 *   server/src/com/cloud/agent/manager/AgentManagerImpl.java (c1bbb58)
 *   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java (3ca74a3)
 *   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java (46ac7af)

View Diff<https://reviews.apache.org/r/9818/diff/>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated March 14, 2013, 3:25 a.m.)


Review request for cloudstack and edison su.


Changes
-------

Add Edison Su as reviewers.


Description (updated)
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by "roxanne_chang@trend.com.tw" <ro...@trend.com.tw>.
Hi Nitin,
So the idea for CS4.2 is to create a secondary storage table in the
future? Cause I just saw secondary_storage_vm table in DB.
And also I would like to ask that can we use this patch for earlier
version? For users who use CS4.0.x or CS4.1.x.
Thanks for replying.

Best regards,
Roxanne.

On 13/3/11 下午12:27, "Nitin Mehta" <Ni...@citrix.com> wrote:

>Roxanne - Thanks very much for working on this.
>My take on the fix was to remove the entry for secondary storage from host
>table as we do not create an agent for it. We should rather have another
>table for secondary storage and related info.
>
>On 11/03/13 7:59 AM, "roxanne chang" <ro...@trend.com.tw> wrote:
>
>>
>>-----------------------------------------------------------
>>This is an automatically generated e-mail. To reply, visit:
>>https://reviews.apache.org/r/9818/
>>-----------------------------------------------------------
>>
>>(Updated March 11, 2013, 2:29 a.m.)
>>
>>
>>Review request for cloudstack.
>>
>>
>>Description
>>-------
>>
>>Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert
>>status
>>[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
>>
>>In file SecondarySotrageManagerImpl.java, function generateSetupCommand,
>>if the host type is Secondary storage VM, the logic is to set
>>secondarystorage host, at this time, secondarystorage host stauts should
>>become Up.
>>
>>The secondary storage host always remains Alert status, because before
>>the secondary storage vm is deployed, the secondary storage host is
>>created. The tricky way (in the end of file AgentManagerImpl.java,
>>function NotifiMonitorsOfConnection) will try to disconnect secondary
>>storage, therefore the secondary storage host becomes Alert status. The
>>code should take SSVM into consider, not only Answer reponse.
>>
>>File ResourceManagerImpl.java, function discoverHostsFull, in the end
>>will call discoverer.postDiscovery, in file
>>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is
>>not needed since its use to make secondary storage host wait for SSVM
>>already done in SecondarySotrageManagerImpl. This makes why secondary
>>storage host always remains Alert status.
>>
>>
>>This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
>>
>>
>>Diffs
>>-----
>>
>>  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58
>>  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java
>>3ca74a3 
>>  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
>>46ac7af 
>>
>>Diff: https://reviews.apache.org/r/9818/diff/
>>
>>
>>Testing
>>-------
>>
>>Test 4.0.0, 4.2.0 in basic mode, works well.
>>
>>
>>Thanks,
>>
>>roxanne chang
>>
>


<table class="TM_EMAIL_NOTICE"><tr><td><pre>
TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.
</pre></td></tr></table>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by Nitin Mehta <Ni...@citrix.com>.
Roxanne - Thanks very much for working on this.
My take on the fix was to remove the entry for secondary storage from host
table as we do not create an agent for it. We should rather have another
table for secondary storage and related info.

On 11/03/13 7:59 AM, "roxanne chang" <ro...@trend.com.tw> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9818/
>-----------------------------------------------------------
>
>(Updated March 11, 2013, 2:29 a.m.)
>
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
>[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
>
>In file SecondarySotrageManagerImpl.java, function generateSetupCommand,
>if the host type is Secondary storage VM, the logic is to set
>secondarystorage host, at this time, secondarystorage host stauts should
>become Up.
>
>The secondary storage host always remains Alert status, because before
>the secondary storage vm is deployed, the secondary storage host is
>created. The tricky way (in the end of file AgentManagerImpl.java,
>function NotifiMonitorsOfConnection) will try to disconnect secondary
>storage, therefore the secondary storage host becomes Alert status. The
>code should take SSVM into consider, not only Answer reponse.
>
>File ResourceManagerImpl.java, function discoverHostsFull, in the end
>will call discoverer.postDiscovery, in file
>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is
>not needed since its use to make secondary storage host wait for SSVM
>already done in SecondarySotrageManagerImpl. This makes why secondary
>storage host always remains Alert status.
>
>
>This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
>
>
>Diffs
>-----
>
>  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58
>  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java
>3ca74a3 
>  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
>46ac7af 
>
>Diff: https://reviews.apache.org/r/9818/diff/
>
>
>Testing
>-------
>
>Test 4.0.0, 4.2.0 in basic mode, works well.
>
>
>Thanks,
>
>roxanne chang
>

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated March 11, 2013, 2:29 a.m.)


Review request for cloudstack.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM already done in SecondarySotrageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated March 11, 2013, 2:29 a.m.)


Review request for cloudstack.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM already done in SecondarySotrageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

Posted by roxanne chang <ro...@trend.com.tw>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/
-----------------------------------------------------------

(Updated March 11, 2013, 2:29 a.m.)


Review request for cloudstack.


Description
-------

Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]

In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse.

File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM already done in SecondarySotrageManagerImpl. This makes why secondary storage host always remains Alert status.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 

Diff: https://reviews.apache.org/r/9818/diff/


Testing
-------

Test 4.0.0, 4.2.0 in basic mode, works well.


Thanks,

roxanne chang