You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/06 22:59:15 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #10066: KAFKA-12278; Ensure exposed api versions are consistent within listener scopes

hachikuji commented on a change in pull request #10066:
URL: https://github.com/apache/kafka/pull/10066#discussion_r571500369



##########
File path: checkstyle/import-control.xml
##########
@@ -99,6 +100,7 @@
       <allow pkg="org.apache.kafka.common.config" />
       <allow pkg="org.apache.kafka.common.metrics" />
       <allow pkg="org.apache.kafka.common.security" />
+      <allow class="org.apache.kafka.common.requests.ApiVersionsResponse" />

Review comment:
       Hmm.. Do you have any ideas? I guess I would say that the dependency is there regardless of how we choose to hide it since we have to go through `ChannelBuilders` to build the authenticator, and the authenticator does depend on the request APIs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org