You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/02 23:30:32 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8719: [Explore] should not trigger chart render when overlay is on

codecov-io commented on issue #8719: [Explore] should not trigger chart render when overlay is on
URL: https://github.com/apache/incubator-superset/pull/8719#issuecomment-560897144
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=h1) Report
   > Merging [#8719](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bca2b9141796041e9143fba86bc8a4f82e9076cb?src=pr&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8719/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8719      +/-   ##
   ==========================================
   + Coverage   65.55%   65.64%   +0.09%     
   ==========================================
     Files         482      482              
     Lines       24083    24087       +4     
     Branches     2763     2767       +4     
   ==========================================
   + Hits        15788    15813      +25     
   + Misses       8115     8094      -21     
     Partials      180      180
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8719/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `39.47% <100%> (+32.52%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=footer). Last update [bca2b91...29e24e4](https://codecov.io/gh/apache/incubator-superset/pull/8719?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org