You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/26 20:27:06 UTC

[GitHub] [trafficserver] shinrich opened a new pull request #7884: Test bad request behavior

shinrich opened a new pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869754967


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869765740


   Here's my run in my ubuntu VM
   `ezelko260@ubuntu tests (7884) $ time ./autest.sh --ats-bin=/opt/ats/bin -f good_request_after_bad
   Python 3.6 or newer detected!
   python3-dev/devel detected!
   pipenv detected!
   Using the pre-existing virtual environment.
   Environment config finished. Running AuTest...
   Running Test good_request_after_bad:.......... Passed
   
   Generating Report: --------------
   Total of 1 test
     Unknown: 0
     Exception: 0
     Failed: 0
     Warning: 0
     Skipped: 0
     Passed: 1
   
   real	4m6.439s
   user	0m4.009s
   sys	0m2.573s
   `
   
   however on a centos7 box
   `real	0m11.043s
   user	0m4.436s
   sys	0m2.547s
   `
   
   So just seems to be an oddity either with running in a vm or the latest ubuntu/environment/etc. So I think its probably fine and just write it off as an oddity of the environment I was trying to run it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-859792790


   Shouldn't be very slow.  I don't think it is relying on timeouts.   Let me look at it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-867016999


   @ezelkow1 I don't know why you are seeing slow test times.  I just ran the test again locally after doing the latest rebase and it took 8.5 seconds.
   
   ```
   [shinrich@atslab02 tests]$ time sh ./autest.sh --ats-bin=/opt/ts-clean/bin --sandbox=/home/shinrich/skh -f good_request_after_bad
   Python 3.6 or newer detected!
   python3-dev/devel detected!
   pipenv detected!
   Using the pre-existing virtual environment.
   Environment config finished. Running AuTest...
   Running Test good_request_after_bad:......... Passed
   
   Generating Report: --------------
   Total of 1 test
     Unknown: 0
     Exception: 0
     Failed: 0
     Warning: 0
     Skipped: 0
     Passed: 1
   
   real	0m8.500s
   user	0m5.819s
   sys	0m1.951s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bryancall commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-868713640


   @ezelkow1 Can you please re-review it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich merged pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-868515490


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 edited a comment on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869765740


   Here's my run in my ubuntu VM
   `
   ezelko260@ubuntu tests (7884) $ time ./autest.sh --ats-bin=/opt/ats/bin -f good_request_after_bad
   Python 3.6 or newer detected!
   python3-dev/devel detected!
   pipenv detected!
   Using the pre-existing virtual environment.
   Environment config finished. Running AuTest...
   Running Test good_request_after_bad:.......... Passed
   
   Generating Report: --------------
   Total of 1 test
     Unknown: 0
     Exception: 0
     Failed: 0
     Warning: 0
     Skipped: 0
     Passed: 1
   
   real	4m6.439s
   user	0m4.009s
   sys	0m2.573s
   `
   
   however on a centos7 box
   `real	0m11.043s
   user	0m4.436s
   sys	0m2.547s
   `
   
   So just seems to be an oddity either with running in a vm or the latest ubuntu/environment/etc. So I think its probably fine and just write it off as an oddity of the environment I was trying to run it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich merged pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich edited a comment on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-867016999


   @ezelkow1 I don't know why you are seeing slow test times.  I just ran the test again locally after doing the latest rebase and it took 8.5 seconds.  And most of that is probably the virtual environment setup.
   
   ```
   [shinrich@atslab02 tests]$ time sh ./autest.sh --ats-bin=/opt/ts-clean/bin --sandbox=/home/shinrich/skh -f good_request_after_bad
   Python 3.6 or newer detected!
   python3-dev/devel detected!
   pipenv detected!
   Using the pre-existing virtual environment.
   Environment config finished. Running AuTest...
   Running Test good_request_after_bad:......... Passed
   
   Generating Report: --------------
   Total of 1 test
     Unknown: 0
     Exception: 0
     Failed: 0
     Warning: 0
     Skipped: 0
     Passed: 1
   
   real	0m8.500s
   user	0m5.819s
   sys	0m1.951s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 edited a comment on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869765740






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 edited a comment on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869765740


   Here's my run in my ubuntu VM
   `
   real	4m6.439s
   user	0m4.009s
   sys	0m2.573s
   `
   
   however on a centos7 box
   `real	0m11.043s
   user	0m4.436s
   sys	0m2.547s
   `
   
   So just seems to be an oddity either with running in a vm or the latest ubuntu/environment/etc. So I think its probably fine and just write it off as an oddity of the environment I was trying to run it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-1030183052


   Cherry-picked to v9.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 commented on pull request #7884: Test bad request behavior

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7884:
URL: https://github.com/apache/trafficserver/pull/7884#issuecomment-869754967






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org