You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/15 08:01:46 UTC
[GitHub] [flink] twalthr opened a new pull request #14660: [FLINK-20883][table-api-java] Support calling SQL expressions in Table API
twalthr opened a new pull request #14660:
URL: https://github.com/apache/flink/pull/14660
## What is the purpose of the change
This supports calling SQL expressions in Table API. It introduces `callSql` which can be used as a regular scalar expression.
## Brief change log
- Introduces `callSql` in all APIs
- Updates several locations and visitors to deal with expressions coming from the planner
## Verifying this change
This change added tests and can be verified as follows: `MiscFunctionITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #14660:
URL: https://github.com/apache/flink/pull/14660#discussion_r560069421
##########
File path: docs/dev/table/functions/systemFunctions.md
##########
@@ -5636,6 +5638,21 @@ STRING.sha2(INT)
<tr>
<td>
{% highlight java %}
+callSql(STRING)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>A call to a SQL expression.</p>
+ <p>The given string is parsed and translated into an Table API expression during planning. Only
Review comment:
```suggestion
<p>The given string is parsed and translated into a Table API expression during planning. Only
```
##########
File path: docs/dev/table/functions/systemFunctions.md
##########
@@ -34,6 +34,8 @@ Scalar Functions
The scalar functions take zero, one or more values as the input and return a single value as the result.
+Note: You can
Review comment:
Something's missing here ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14660: [FLINK-20883][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14660:
URL: https://github.com/apache/flink/pull/14660#issuecomment-760725035
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 08a9fff38a4698b216fbc9cd5c25c7875db0e827 (Fri Jan 15 08:04:39 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #14660:
URL: https://github.com/apache/flink/pull/14660#discussion_r560146069
##########
File path: docs/dev/table/functions/systemFunctions.md
##########
@@ -34,6 +34,8 @@ Scalar Functions
The scalar functions take zero, one or more values as the input and return a single value as the result.
+Note: You can
Review comment:
yes, the line should not be present anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #14660:
URL: https://github.com/apache/flink/pull/14660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14660: [FLINK-20883][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14660:
URL: https://github.com/apache/flink/pull/14660#issuecomment-760748649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12104",
"triggerID" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08a9fff38a4698b216fbc9cd5c25c7875db0e827 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12104)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14660: [FLINK-20883][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14660:
URL: https://github.com/apache/flink/pull/14660#issuecomment-760748649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08a9fff38a4698b216fbc9cd5c25c7875db0e827 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14660:
URL: https://github.com/apache/flink/pull/14660#issuecomment-760725035
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 08a9fff38a4698b216fbc9cd5c25c7875db0e827 (Fri May 28 07:10:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14660: [FLINK-20883][table-api-java] Support calling SQL expressions in Table API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14660:
URL: https://github.com/apache/flink/pull/14660#issuecomment-760748649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12104",
"triggerID" : "08a9fff38a4698b216fbc9cd5c25c7875db0e827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08a9fff38a4698b216fbc9cd5c25c7875db0e827 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12104)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org