You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2021/10/18 12:18:33 UTC
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
zchovan@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17940
Change subject: Fix deprecation error of the --path flag
......................................................................
Fix deprecation error of the --path flag
When building the jekyll site the ruby bundler throws a deprecation
warning for using the --path flag.
Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
---
M site_tool
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/17940/1
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Thu, 21 Oct 2021 18:32:56 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool@107
PS1, Line 107: subprocess.check_call([BUNDLE_PATH, "config", "set", "--local", "path", GEM_PATH])
> tested it with ruby 2.4.0 and it worked, also:
Could you a note about testing in the commit message along with versions of Ruby?
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Oct 2021 20:14:15 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Fix deprecation error of the --path flag
When building the jekyll site the ruby bundler throws a deprecation
warning for using the --path flag.
Tested successfully with Ruby 2.4.0.
The flag was deprecated in bundler 2.1 - https://github.com/capistrano/bundler/issues/115
Bundler compatibility guide - https://bundler.io/compatibility.html
Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Reviewed-on: http://gerrit.cloudera.org:8080/17940
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M site_tool
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Attila Bukor: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool@107
PS1, Line 107: subprocess.check_call([BUNDLE_PATH, "config", "set", "--local", "path", GEM_PATH])
does this work on older ruby versions as well?
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Mon, 18 Oct 2021 14:35:44 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zchovan@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/17940/1/site_tool@107
PS1, Line 107: subprocess.check_call([BUNDLE_PATH, "config", "set", "--local", "path", GEM_PATH])
> does this work on older ruby versions as well?
tested it with ruby 2.4.0 and it worked, also:
https://github.com/capistrano/bundler/issues/115 -- the flag was deprecated in bundler 2.1
https://bundler.io/compatibility.html -- based on bundler compatibility guide, it should work
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Comment-Date: Mon, 18 Oct 2021 15:00:48 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17940
to look at the new patch set (#2).
Change subject: Fix deprecation error of the --path flag
......................................................................
Fix deprecation error of the --path flag
When building the jekyll site the ruby bundler throws a deprecation
warning for using the --path flag.
Tested successfully with Ruby 2.4.0.
The flag was deprecated in bundler 2.1 - https://github.com/capistrano/bundler/issues/115
Bundler compatibility guide - https://bundler.io/compatibility.html
Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
---
M site_tool
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/17940/2
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR](gh-pages) Fix deprecation error of the --path flag
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17940 )
Change subject: Fix deprecation error of the --path flag
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be95e5454e73f72edaa544abb132b0574c73f17
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Oct 2021 09:33:29 +0000
Gerrit-HasComments: No