You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/06 11:36:09 UTC

[GitHub] [calcite] divyanshuS27 commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates

divyanshuS27 commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates
URL: https://github.com/apache/calcite/pull/1636#discussion_r354791077
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/SparkSqlDialect.java
 ##########
 @@ -70,6 +70,10 @@ public SparkSqlDialect(SqlDialect.Context context) {
     return true;
   }
 
+  @Override public boolean supportsNestedAggregations() {
+    return false;
+  }
+
 
 Review comment:
   @chunweilei and @amaliujia  point duly noted. Would it be right to say that ### BigQuery, Hive, Spark SQL dialects do not explicitly support nested aggregates?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services