[GitHub] [ozone] bshashikant commented on pull request #1953: HDDS-4718. Bootstrap new SCM node

[GitBox <gi...@apache.org>]

bshashikant commented on pull request #1953:
URL: https://github.com/apache/ozone/pull/1953#issuecomment-787475756


   > Overall LGTM. One comment regarding usage of clientID and callID usage need to be set from Server API's that looks missing.
   > And also getting localNodeID need to be fetched, as setNodeSpecificConfigKeys does not ozone.scm.node.id.
   
   There is only one central place of submitting ratis requests and there is only client Id which will be same for all requests submitted to the server on each node. I don't think , we need to get the clientId from server here as there is only one client.
   Same goes for "callId" as well.
   
   However, this change is not related to the patch. We can discuss it further and make change accordingly, in a different jira.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org