You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2015/01/01 14:45:35 UTC

[Issue 125988] New: Text for dropdown box within view dialog too long

https://issues.apache.org/ooo/show_bug.cgi?id=125988

          Issue ID: 125988
        Issue Type: PATCH
           Summary: Text for dropdown box within view dialog too long
           Product: General
           Version: 4.2.0-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: thorsten.wagner.4@gmail.com
                CC: hdu@apache.org

Created attachment 84341
  --> https://issues.apache.org/ooo/attachment.cgi?id=84341&action=edit
Patch

The text "Automatic (Galaxy (default))" for the style dropdown box within
preferences / OpenOffice / view dialog is too long.

I supplied a patch attached to this bug report.

The current dialog is shown in "Screenshot without patch.png" attached to this
bug report. The affected dropdown box is marked with a red box.

With patch applied the result is shown in "Screenshot with patch.png". The
affected dropdown box is marked with a red box again.

In addition I adjusted the check box text label "Screen font antialiasing". The
position of the remaining dialog elements on the dialog's left side are
adjusted too.

I'm able to test on Mac OS X only. The patch has to be retested on Mac OS X,
but it has to be tested on Windows and Linux too.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

review denied: [Issue 125988] Text for dropdown box within view dialog too long : [Attachment 84341] Patch

Posted by bu...@apache.org.
Regina Henschel <rb...@t-online.de> has denied  review:
Issue 125988: Text for dropdown box within view dialog too long
https://issues.apache.org/ooo/show_bug.cgi?id=125988

Attachment 84341: Patch
https://issues.apache.org/ooo/attachment.cgi?id=84341&action=edit

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84341|                            |review-
              Flags|                            |
                 CC|                            |rb.henschel@t-online.de

--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
Comment on attachment 84341
  --> https://issues.apache.org/ooo/attachment.cgi?id=84341
Patch

The patch removes the title case of the headings in the dialog. I think, that
those headings should remain in title case.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #1 from Thorsten Wagner <th...@gmail.com> ---
Created attachment 84342
  --> https://issues.apache.org/ooo/attachment.cgi?id=84342&action=edit
Screenshot without patch

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #7 from Regina Henschel <rb...@t-online.de> ---
You are right about the capital letters, not all but most headings do not use
title case. That is different to LibreOffice. So your change is acceptable.

The problem with the line wrap remains.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #6 from Thorsten Wagner <th...@gmail.com> ---
I don't see any inconsistency. Only the first word is using capital letters at
the beginning. This is consistent to the other preference dialogs. But there
are other dialog boxes, e.g. hyperlink tab in Writer's character formatting
dialog, which are using capital letters at the beginning of all words. The
right formatting has to be defined. Currently most of the dialogs are using
only a single capital letter at the beginning.

Reason of removing line wrap was a shift of the text slight up with OS X. This
shift is caused by the line wrap. I'll try to find a better solution preserving
line wrap.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #5 from Regina Henschel <rb...@t-online.de> ---
Your patch does
User Interface --> User interface
Font Lists --> Font lists

I have noticed, that the headings in that dialog are inconsistent formated.
Solution would be to change
Graphics output --> Graphics Output

A new issue about this inconsistency should be generated with a separate patch
for only that problem. Having patches for single problems makes it easier to
find the connection between code change and problem in the history of the code.


An additional problem is, that your patch removes the line wrap in the text
"Use system font for user interface"
But that line wrap is needed for some languages. For example in German the text
is
"Systemschriftart für die Benutzeroberfläche verwenden"
That is much longer than the English text and would not fit without line break.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #2 from Thorsten Wagner <th...@gmail.com> ---
Created attachment 84343
  --> https://issues.apache.org/ooo/attachment.cgi?id=84343&action=edit
Screenshot with patch

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125988] Text for dropdown box within view dialog too long

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125988

--- Comment #4 from Thorsten Wagner <th...@gmail.com> ---
(In reply to Regina Henschel from comment #3)
> Comment on attachment 84341 [details]
> Patch
> 
> The patch removes the title case of the headings in the dialog. I think,
> that those headings should remain in title case.

I don't know what exactly is removed here from you point of view. It would be
very nice to have a screenshot attached for better understanding.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.