[GitHub] [helix] openrefactory opened a new pull request #528: Suggested fixes by iCR, OpenRefactory, Inc.

[GitBox <gi...@apache.org>]

openrefactory opened a new pull request #528: Suggested fixes by iCR, OpenRefactory, Inc.
URL: https://github.com/apache/helix/pull/528
 
 
   OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on your code. We are reporting a few sample fixes that were generated.
   The goal of the this fix is to resolve **Unchecked Method Return Value**, **Bad Flow in Switch** and **Weak Library Usage** problem. 
   
   ### Unchecked Method Return Value fixes:
   In file: `TestFullAutoNodeTagging.java`, method:` withinAverage ` returns one or more error return value(s) that have not been checked properly. iCR suggested that the checks are done properly.
   
   ### Bad Flow in Switch fixes:
   In file: `AbstractTaskDispatcher.java`, class: `AbstractTaskDispatcher`, method: `updatePreviousAssignedTasksStatus`  has a case statement that is not terminated by a break . iCR suggested changes in 1 files to resolve the problem.
   
   In file: `TestExecutor.java`, class:` TestExecutor`, method:` getValueType`  has a case statement that is not terminated by a break . iCR suggested changes in 1 files to resolve the problem.
   
   ### Weak Library Usage fixes:
   In file: `TaskExecutionDemo.java`, class: `TaskExecutionDemo,` method: `populateDummyData`  uses Random object but it may not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1 files to resolve the problem.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org