[GitHub] [airflow] uranusjr commented on a diff in pull request #28398: raise ValueError when logical date is earlier than start_date

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28398:
URL: https://github.com/apache/airflow/pull/28398#discussion_r1050553683


##########
airflow/api/common/trigger_dag.py:
##########
@@ -51,7 +51,11 @@ def _trigger_dag(
     if dag is None or dag_id not in dag_bag.dags:
         raise DagNotFound(f"Dag id {dag_id} not found")
 
-    execution_date = execution_date if execution_date else timezone.utcnow()
+    if execution_date is None:
+        if conf and "logical_date" in conf:
+            execution_date = conf["logical_date"]

Review Comment:
   I don’t recall specifying `logical_date` in trigger config being a valid usage? Why is this added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org