You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 13:48:58 UTC

[GitHub] [airflow] JeffryMAC commented on a change in pull request #13847: Add ExasolToS3Operator

JeffryMAC commented on a change in pull request #13847:
URL: https://github.com/apache/airflow/pull/13847#discussion_r563154826



##########
File path: airflow/providers/exasol/hooks/exasol.py
##########
@@ -108,6 +108,37 @@ def get_first(self, sql: Union[str, list], parameters: Optional[dict] = None) ->
             with closing(conn.execute(sql, parameters)) as cur:
                 return cur.fetchone()
 
+    def export_to_file(

Review comment:
       does it offer the choice of file format? (json, csv, other?)
   The method name doesn't suggest it's generic so suitable for more than one file extension but there is no file extension parameter to config




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org