You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/23 13:12:00 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

bartekkuncer opened a new pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944


   From https://github.com/apache/incubator-mxnet/issues/19610:
   
   > Intel MKL-DNN was renamed with DNNL in its v1.1 release. Since then, the MXNet community has been working on the transition to DNNL to leverage the latest features and optimizations from the library. That includes using the string “DNNL” or “dnnl” for future development and communication. We propose to promote the flag “USE_DNNL” since MXNet 2.0 and start deprecating “USE_MKLDNN” at the same time.
   > DNNL source code resides in the 3rdparty/mkldnn folder of the MXNet repository and is released and distributed along with MXNet source code. If one wants to build MXNet with DNNL to accelerate the execution on Intel CPU, she/he needs to enable -DUSE_DNNL=ON in CMake. However, this flag has been set to ON by default for all platforms except edge devices. On the contrary, to disable the DNNL acceleration, one needs to set -DUSE_DNNL=OFF explicitly in the CMake command line or the CMake configuration file.
   > As both MXNet and DNNL are under quick development with different release cadence, we decide to link the DNNL library into MXNet statically to avoid mis-linking in the user's environment. Given this, we need to set DNNL_LIBRARY_TYPE to STATIC when building DNNL.
   > Some additional flags to build DNNL:
   > 
   > DNNl_CPU_RUNTIME: Need set it to SEQ explicitly when USE_OPENMP=OFF;
   > DNNL_ARCH_OPT_FLAGS: Need pass compiler options to this build flag in string. Eg. -march or -mtune for GCC.
   > MKLDNN_BUILD_TESTS and MKLDNN_BUILD_EXAMPLES: We set these two flags to OFF to speed up the compilation.
   > One thing that needs to be taken care of is that the header dnnl_config.h and dnnl_version.h will be generated dynamically during compilation and will be copied to the installation destination when calling make install. That means these two headers are not distributed with DNNL source code. For downstream projects which are including these headers need to find them in the installation path rather than the source code path.
   
   I prepared two commits regarding this point of main RFC:
   1. changing USE_MKLDNN flag name to USE_ONEDNN to make it consistent with actual library name
   I believe that this commit is complete and if there is such a will can be merged into master.
   
   2. changing MXNET_USE_MKLDNN* flags names to MXNET_USE_ONEDNN* also for consistency reasons
   This commit regards changing inner MXNET flag so that it will be consistent with the actual lib name. To avoid creating even bigger mixture of mkldnn/dnnl/onednn acronyms I believe it should be accompanied with another commit changing acronyms used in mxnet function names and comments regarding this particular lib to oneDNN. What do you think about it?
   
   There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-787700691


   > > @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?
   > 
   > This is a good idea, but we can break things. Alpha is more of a preview than something that requires API compatibility. We can merge this change now and it can show up in the Beta or the final release.
   
   @samskalicky I did not comment on that but already added back the support for an old flag: https://github.com/apache/incubator-mxnet/pull/19944/commits/020c892e9509e0a8a3ca5298d802fbf8e371812a.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789711108


   @mxnet-bot run ci [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-797514752


   @mxnet-bot run ci [unix-cpu, centos-cpu]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790473786


   @mxnet-bot run ci [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588401163



##########
File path: docs/static_site/src/pages/api/faq/env_var.md
##########
@@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Review comment:
       Changed.

##########
File path: docs/static_site/src/pages/api/faq/env_var.md
##########
@@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Review comment:
       Changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-797428950


   Jenkins CI successfully triggered : [unix-cpu, centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] TaoLv commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786451703


   Will this cause any incompatible issue for downstream projects? I'm not sure if there is any using the master branch and the alpha release is already in process.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784430683


   > There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.
   
   since this is the master branch, and we're moving from 1.x to 2.0 shouldnt this be the time to make this change? Having a directory named "mkldnn" but using "onednn" everywhere will only cause confusion in the future for those who do not have the historical background. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792866409


   @mxnet-bot run ci [website,windows-gpu]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-793532903


   Jenkins CI successfully triggered : [unix-cpu, centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784192597


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, unix-cpu, windows-gpu, centos-cpu, sanity, centos-gpu, miscellaneous, windows-cpu, unix-gpu, clang, website]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788885396


   Jenkins CI successfully triggered : [windows-gpu, centos-gpu, miscellaneous, edge, unix-cpu, clang, unix-gpu, centos-cpu, website, windows-cpu, sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799391466


   Jenkins CI successfully triggered : [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786464386


   > @leezu, do we claim any API compatibility on an alpha release or is it possible to include this into the alpha release?
   > 
   > @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?
   
   @TaoLv I believe we might keep it for some time. Will add it by eod.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790750970


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785885657


   I adjusted the change of USE_MKLDNN flags to USE_ONEDNN by changing the library name in comments around it.
   The changes regarding the USE_MKLDNN compilation flag, submodule directory name and the MXNET_USE_(MKL)ONEDNN seem to be complete.
   
   After team discussion we agreed that as having all oneDNNs acronyms unified to one is desirable, it is impossible to be achieved as long as there is no update of oneDNNs functions/flags names from dnnl*/mkldnn* nomenclature. Therefore we believe that further efforts to unify oneDNNs acronyms should be postponed at least till we get an updated api.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer edited a comment on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer edited a comment on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-787700691


   > > @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?
   > 
   > This is a good idea, but we can break things. Alpha is more of a preview than something that requires API compatibility. We can merge this change now and it can show up in the Beta or the final release.
   
   @samskalicky I did not comment on that but already added back the support for the old flag: https://github.com/apache/incubator-mxnet/pull/19944/commits/020c892e9509e0a8a3ca5298d802fbf8e371812a.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784423526


   Jenkins CI successfully triggered : [windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-794353153


   @szha @samskalicky @leezu Hi, I am struggling to find the reason why website and windows-gpu checks are failing. I see in the logs that there was a problem during `git merge` but locally, here on github and in other checks I do not see such problems. It seems like all the failing checks are run on the same machine `Running on utility_0se3punbeq in /home/jenkins_slave/workspace/xnet-validation_website_PR-19944`. Do you know what is/might be the problem here or have an advice on how should I proceed to find the issue in the fastest way? Maybe there are some artifacts which interrupt the merge? Thanks for your attention. I’m looking forward to your reply.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786457204


   @TaoLv it might if somebody is trying to build mxnet without mkldnn, as the old compilation flag will not work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789518308


   Jenkins CI successfully triggered : [unix-cpu, sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790759928


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790763596


   > @szha Sure, thanks for help. It is quite strange that the merging worked for all other checks.
   
   I suspect the status for the other checks was outdated. For cost savings, the Sanity check is triggered automatically by Github if needed and the other checks are only retriggered if the Sanity check passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792554015


   Jenkins CI successfully triggered : [windows-gpu, website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha removed a comment on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha removed a comment on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795756626


   @mxnet-bot run ci all


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785199514


   I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799469248


   @mxnet-bot run ci [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-797428892


   @mxnet-bot run ci [unix-cpu, centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789710367


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795757203


   @mxnet-bot run ci [all]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588400970



##########
File path: docs/python_docs/python/tutorials/performance/backend/mkldnn/mkldnn_readme.md
##########
@@ -62,18 +62,18 @@ To achieve better performance, the Intel OpenMP and llvm OpenMP are recommended
 ```

Review comment:
       Changed the names, but left the file name. I believe it should be changed later if the file nomenclature will change from mkldnn to onednn in whole project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790408927


   > It complains that the commit is not mergeable: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-19944/15/pipeline#log-42
   > 
   > @bartekkuncer would you mind doing a rebase to the latest master branch and do a force push?
   
   @szha Sure, thanks for help. It is quite strange that the merging worked for all other checks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795756746


   Undefined action detected. 
   Permissible actions are : run ci [all], run ci [job1, job2] 
   Example : @mxnet-bot run ci [all] 
   Example : @mxnet-bot run ci [centos-cpu, clang]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792866481


   Jenkins CI successfully triggered : [website, windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788886647


   @mxnet-bot run ci [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795757384


   Jenkins CI successfully triggered : [sanity, centos-gpu, edge, windows-cpu, clang, miscellaneous, website, centos-cpu, windows-gpu, unix-gpu, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788885334


   @mxnet-bot run ci [all]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785123418


   Added commit regarding changing name of the submodule directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] TaoLv edited a comment on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
TaoLv edited a comment on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786451703


   Will this cause any incompatible issue for downstream projects? I'm not sure if there is any using the master branch or the alpha release which is already in process.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789213359


   @mxnet-bot run ci [sanity,unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799545535


   @szha @leezu @samskalicky Please help with the merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795756626


   @mxnet-bot run ci all


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-797514800


   Jenkins CI successfully triggered : [unix-cpu, centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795855255


   Looks like the merge issue still exists and I'm still not sure what's causing it after searching jenkins jira (e.g. [this one](https://issues.jenkins.io/browse/JENKINS-44598). Maybe you could try squashing the 6 commits to a single one and push again?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784315863


   @mxnet-bot run ci [centos-gpu, windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789213445


   Jenkins CI successfully triggered : [sanity, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784315962


   Jenkins CI successfully triggered : [centos-gpu, windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#discussion_r589347835



##########
File path: CMakeLists.txt
##########
@@ -62,10 +62,14 @@ option(USE_F16C "Build with x86 F16C instruction support" ON) # autodetects supp
 option(USE_LAPACK "Build with lapack support" ON)
 option(USE_MKL_IF_AVAILABLE "Use MKL if found" ON)
 option(USE_MKL_LAYERNORM "Use layer normalization from MKL, which is currently slower than internal.  No effect unless USE_MKL_IF_AVAILABLE is set." OFF)
+if(DEFINED USE_MKLDNN)
+  message(WARNING "USE_MKLDNN is deprecated and will stop being supported soon. Please use USE_ONEDNN instead.")
+  set(USE_ONEDNN ${USE_MKLDNN})
+endif()
 if(USE_MKL_IF_AVAILABLE AND (NOT APPLE) AND (NOT MSVC) AND (CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "x86_64") AND (NOT CMAKE_CROSSCOMPILING))
-  option(USE_MKLDNN "Build with MKL-DNN support" ON)
+  option(USE_ONEDNN "Build with MKL-DNN support" ON)

Review comment:
       This will be addressed in separate PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789711139


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784423476


   @mxnet-bot run ci [windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789713720


   Does anyone know why sanity check is stuck in "Expected — Waiting for status to be reported" and "@mxnet-bot run ci [sanity]" does nothing?
   
   @samskalicky @leezu @szha Do you have any concerns regarding this change? If not I believe we can merge it into master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789713755


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-793532786


   @mxnet-bot run ci [centos-cpu,unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789829072


   It complains that the commit is not mergeable: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-19944/15/pipeline#log-42
   
   @bartekkuncer would you mind doing a rebase to the latest master branch and do a force push?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] TaoLv commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786462847


   @leezu, do we claim any API compatibility on an alpha release or is it possible to include this into the alpha release?
   
   @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789710299


   @mxnet-bot run ci [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792257524


   @mxnet-bot run ci [website,windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788886679


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784979174


   > > There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.
   > 
   > since this is the master branch, and we're moving from 1.x to 2.0 shouldnt this be the time to make this change? Having a directory named "mkldnn" but using "onednn" everywhere will only cause confusion in the future for those who do not have the historical background.
   
   Ok, will add it soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799391388


   @mxnet-bot run ci [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785705854


   > > I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.
   > 
   > Can you give an example, which acronyms are you referring to?
   
   Before v1.1 of oneDNN it was called MKLDNN, then dnnl up until some time ago. Due to that we have a mixture of different acronyms used in the code and unifying them using the most recent one can help avoid some unnecessary confusion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790759987


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588332103



##########
File path: docs/static_site/src/pages/api/faq/env_var.md
##########
@@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Review comment:
       should be ``pip install mxnet`` as oneDNN is enabled by default
   

##########
File path: docs/static_site/src/pages/api/faq/env_var.md
##########
@@ -399,7 +399,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
   - Values: 0(false) or 1(true) ```(default=1)```
   - If this variable is set, MXNet will simplify the computation graph, eliminating duplicated operations on the same inputs.
 
-* MXNET_USE_MKLDNN_RNN
+* MXNET_USE_ONEDNN_RNN
   - Values: 0(false) or 1(true) ```(default=1)```
   - This variable controls whether to use the MKL-DNN backend in fused RNN operator for CPU context. There are two fusion implementations of RNN operator in MXNet. The MKL-DNN implementation has a better performance than the naive one, but the latter is more stable in the backward operation currently.

Review comment:
       old name

##########
File path: docs/python_docs/python/tutorials/performance/backend/mkldnn/mkldnn_readme.md
##########
@@ -62,18 +62,18 @@ To achieve better performance, the Intel OpenMP and llvm OpenMP are recommended
 ```

Review comment:
       Old MKL-DNN names starting from line 18.
   Maybe the directory and file name could be also changed

##########
File path: CMakeLists.txt
##########
@@ -62,10 +62,14 @@ option(USE_F16C "Build with x86 F16C instruction support" ON) # autodetects supp
 option(USE_LAPACK "Build with lapack support" ON)
 option(USE_MKL_IF_AVAILABLE "Use MKL if found" ON)
 option(USE_MKL_LAYERNORM "Use layer normalization from MKL, which is currently slower than internal.  No effect unless USE_MKL_IF_AVAILABLE is set." OFF)
+if(DEFINED USE_MKLDNN)
+  message(WARNING "USE_MKLDNN is deprecated and will stop being supported soon. Please use USE_ONEDNN instead.")
+  set(USE_ONEDNN ${USE_MKLDNN})
+endif()
 if(USE_MKL_IF_AVAILABLE AND (NOT APPLE) AND (NOT MSVC) AND (CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "x86_64") AND (NOT CMAKE_CROSSCOMPILING))
-  option(USE_MKLDNN "Build with MKL-DNN support" ON)
+  option(USE_ONEDNN "Build with MKL-DNN support" ON)

Review comment:
       Why one DNN depends on existing of MKL library ? Is oneDNN still dependent on MKL?

##########
File path: docs/static_site/src/pages/api/faq/env_var.md
##########
@@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Review comment:
       l329 OneDNN ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-796800171


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790750904


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789016545


   Jenkins CI successfully triggered : [sanity, windows-gpu, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789827387


   @bartekkuncer no idea. Because sanity check is a required check, committers can't click on merge button if it's not green.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer edited a comment on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer edited a comment on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784979174


   > > There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.
   > 
   > since this is the master branch, and we're moving from 1.x to 2.0 shouldnt this be the time to make this change? Having a directory named "mkldnn" but using "onednn" everywhere will only cause confusion in the future for those who do not have the historical background.
   
   @samskalicky Ok, will add it soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786817126


   > @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?
   
   This is a good idea, but we can break things. Alpha is more of a preview than something that requires API compatibility. We can merge this change now and it can show up in the Beta or the final release. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785242710


   > I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.
   
   Can you give an example, which acronyms are you referring to?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789016461


   @mxnet-bot run ci [sanity,unix-cpu,windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788883188


   Fixed merge conflicts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792257537


   Jenkins CI successfully triggered : [website, windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-792553952


   @mxnet-bot run ci [website,windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot removed a comment on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot removed a comment on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795756746


   Undefined action detected. 
   Permissible actions are : run ci [all], run ci [job1, job2] 
   Example : @mxnet-bot run ci [all] 
   Example : @mxnet-bot run ci [centos-cpu, clang]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788876414


   Jenkins CI successfully triggered : [unix-gpu, windows-gpu, sanity, centos-cpu, windows-cpu, website, centos-gpu, clang, edge, unix-cpu, miscellaneous]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799469303


   Jenkins CI successfully triggered : [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-796800221


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789518269


   @mxnet-bot run ci [sanity,unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788876322


   @mxnet-bot run ci [all]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790473843


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19944: [RFC] Build with MKL-DNN (or DNNL)

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19944:
URL: https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784252538


   CC: @leezu, @TaoLv, @anko-intel, @szha, @akarbown 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org