You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@apache.org by Karl Heinz Marbaise <kh...@gmx.de> on 2019/12/27 10:38:08 UTC

Question about GitHub Pull Request Builds on ASF

Hi,

currently I'm a little bit unsure based on previous discussions etc. I
thought pull requests from GitHub should not run on ASF infrastructure
(Jenkins)...but based on the current oberservations I see that project
doing exactly this...

Has the general opinion changed about Pull Request builds?


Kind regards
Karl Heinz Marbaise

Re: Question about GitHub Pull Request Builds on ASF

Posted by Enrico Olivelli <eo...@gmail.com>.
Il ven 27 dic 2019, 11:38 Karl Heinz Marbaise <kh...@gmx.de> ha
scritto:

> Hi,
>
> currently I'm a little bit unsure based on previous discussions etc. I
> thought pull requests from GitHub should not run on ASF infrastructure
> (Jenkins)...but based on the current oberservations I see that project
> doing exactly this...
>

Which projects ?
In the other projects I am working on (Bookkeeper, Zookeeper) we have been
running tests against Pull requests for years

I think that the only show stopper for us in Maven is the architecture
Maven box.
It should take github as source.
Github repositories see pull requests as regular branches


Enrico


> Has the general opinion changed about Pull Request builds?
>
>
> Kind regards
> Karl Heinz Marbaise
>

Re: Question about GitHub Pull Request Builds on ASF

Posted by Lukasz Lenart <lu...@apache.org>.
pt., 27 gru 2019 o 11:38 Karl Heinz Marbaise <kh...@gmx.de> napisał(a):
> currently I'm a little bit unsure based on previous discussions etc. I
> thought pull requests from GitHub should not run on ASF infrastructure
> (Jenkins)...but based on the current oberservations I see that project
> doing exactly this...
>
> Has the general opinion changed about Pull Request builds?

When using Multibranch Pipeline Job you can define Trust option to
allow only PRs from ASF Members to be run on ASF Jenkins.

Compare those two PRs, the Checks section, and you will notice that my
PR was run on the Jenkins but another PR from collaborator was ignored
and we use TravisCI to build such PRs

https://github.com/apache/struts/pull/389
https://github.com/apache/struts/pull/391


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/