You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicemix.apache.org by "Jean-Baptiste Onofré (Jira)" <ji...@apache.org> on 2023/03/10 09:46:00 UTC

[jira] [Comment Edited] (SM-5499) Upgrade snappy-java to 1.1.9.1 in kafka-clients

    [ https://issues.apache.org/jira/browse/SM-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698845#comment-17698845 ] 

Jean-Baptiste Onofré edited comment on SM-5499 at 3/10/23 9:45 AM:
-------------------------------------------------------------------

[~jjramos] you are mixing two things here: the build and the runtime.

At build, kafka-client bundle depends to kafka-client, itself depending to snappy:
{code:java}
[INFO] --- maven-dependency-plugin:3.3.0:tree (default-cli) @ org.apache.servicemix.bundles.kafka-clients ---
[INFO] org.apache.servicemix.bundles:org.apache.servicemix.bundles.kafka-clients:bundle:3.3.2_2-SNAPSHOT
[INFO] +- org.apache.kafka:kafka-clients:jar:3.3.2:compile
[INFO] |  +- com.github.luben:zstd-jni:jar:1.5.2-1:runtime
[INFO] |  +- org.lz4:lz4-java:jar:1.8.0:runtime
[INFO] |  +- org.xerial.snappy:snappy-java:jar:1.1.8.4:runtime
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.36:runtime
[INFO] \- org.apache.kafka:kafka-clients:jar:sources:3.3.2:compile {code}
But it's not a problem at runtime as you can define snappy bundle (in Karaf for instance). For instance, in Karaf:

 
{code:java}
52 │ Active   │  80 │ 3.3.1.1            │ Apache ServiceMix :: Bundles :: kafka-clients
53 │ Active   │  80 │ 1.1.9.1            │ snappy-java: A fast compression/decompression library
{code}
you can see snappy 1.1.9.1 installed and kafka-clients 3.3.1.1 installed as well.

 
{code:java}
karaf@root()> bundle:tree-show 52
Bundle org.apache.servicemix.bundles.kafka-clients [52] is currently ACTIVE 
org.apache.servicemix.bundles.kafka-clients [52]
+- org.xerial.snappy.snappy-java [53]
+- org.ops4j.pax.logging.pax-logging-api [5]
   +- org.apache.karaf.services.eventadmin [4]
      +- org.apache.felix.metatype [3]
      +- org.apache.felix.configadmin [12]
         +- org.apache.felix.coordinator [10]
{code}
kafka-clients 3.3.1.1 bundle uses snappy 1.1.9.1.

If you are not using OSGi, just use kafka-clients directly.

If you are using OSGi, the deps in kafka-clients bundle doesn't matter.


was (Author: jbonofre):
[~jjramos] you are mixing two things here: the build and the runtime.

At build, kafka-client bundle depends to kafka-client, itself depending to snappy:
{code:java}
[INFO] --- maven-dependency-plugin:3.3.0:tree (default-cli) @ org.apache.servicemix.bundles.kafka-clients ---
[INFO] org.apache.servicemix.bundles:org.apache.servicemix.bundles.kafka-clients:bundle:3.3.2_2-SNAPSHOT
[INFO] +- org.apache.kafka:kafka-clients:jar:3.3.2:compile
[INFO] |  +- com.github.luben:zstd-jni:jar:1.5.2-1:runtime
[INFO] |  +- org.lz4:lz4-java:jar:1.8.0:runtime
[INFO] |  +- org.xerial.snappy:snappy-java:jar:1.1.8.4:runtime
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.36:runtime
[INFO] \- org.apache.kafka:kafka-clients:jar:sources:3.3.2:compile {code}
But it's not a problem at runtime as you can define snappy bundle (in Karaf for instance). For instance, in Karaf:

 
{code:java}
52 │ Active   │  80 │ 3.3.1.1            │ Apache ServiceMix :: Bundles :: kafka-clients
53 │ Active   │  80 │ 1.1.9.1            │ snappy-java: A fast compression/decompression library
{code}
you can see snappy 1.1.9.1 installed and kafka-clients 3.3.1.1 installed as well.

 
{code:java}
karaf@root()> bundle:tree-show 52
Bundle org.apache.servicemix.bundles.kafka-clients [52] is currently ACTIVE org.apache.servicemix.bundles.kafka-clients [52]
+- org.xerial.snappy.snappy-java [53]
+- org.ops4j.pax.logging.pax-logging-api [5]
   +- org.apache.karaf.services.eventadmin [4]
      +- org.apache.felix.metatype [3]
      +- org.apache.felix.configadmin [12]
         +- org.apache.felix.coordinator [10]
{code}
 

 

> Upgrade snappy-java to 1.1.9.1 in kafka-clients
> -----------------------------------------------
>
>                 Key: SM-5499
>                 URL: https://issues.apache.org/jira/browse/SM-5499
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: bundles
>            Reporter: Juan Ramos
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>
> The current {{kafka-clients}} latest released versions depend on {{snappy-java}} {{1.1.8.4}}. This particular version is affected by [bug 302|https://github.com/xerial/snappy-java/issues/302], which causes problems when using the bundle on ARM based architectures. The bug itself has been fixed in version {{1.1.9.0}}, could the {{kafka-clients}} bundle be updated to transitively include the fixed version of {{snappy-java}}?.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)