You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/25 16:29:58 UTC
[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #641:
[SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
coolbeevip opened a new pull request #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641
Configure PAYLOADS_MAX_LENGTH parameter from os environment variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request
#641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641#discussion_r398497451
##########
File path: pack-common/src/main/java/org/apache/servicecomb/pack/common/Environment.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.common;
+
+public class Environment {
+ private static Environment instance;
+ private static final int PAYLOADS_MAX_LENGTH = 10240;
+ private int payloadsMaxLength = 0;
+
+ public Environment() {
+ if (payloadsMaxLength == 0) {
+ String val = System.getenv("PAYLOADS_MAX_LENGTH");
+ if (val == null || val.trim().length() == 0) {
+ payloadsMaxLength = PAYLOADS_MAX_LENGTH;
+ } else {
+ try {
+ payloadsMaxLength = Integer.parseInt(val);
+ } catch (NumberFormatException ex) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coveralls edited a comment on issue #641:
[SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641#issuecomment-603964107
[](https://coveralls.io/builds/29632426)
Coverage decreased (-0.04%) to 80.816% when pulling **6e2ba6d4938775ab51b917023953688715d2c0ae on coolbeevip:SCB-1811** into **97b95589184381b56c7ba37e301ce1c077547f0d on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coveralls commented on issue #641: [SCB-1811]
Configure PAYLOADS_MAX_LENGTH parameter from os environment
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641#issuecomment-603964107
[](https://coveralls.io/builds/29612007)
Coverage remained the same at 80.858% when pulling **4387a2c610d8282fc1668182b79e459e3a42916a on coolbeevip:SCB-1811** into **97b95589184381b56c7ba37e301ce1c077547f0d on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull
request #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os
environment
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641#discussion_r398374878
##########
File path: pack-common/src/main/java/org/apache/servicecomb/pack/common/Environment.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.common;
+
+public class Environment {
+ private static Environment instance;
+ private static final int PAYLOADS_MAX_LENGTH = 10240;
+ private int payloadsMaxLength = 0;
+
+ public Environment() {
+ if (payloadsMaxLength == 0) {
+ String val = System.getenv("PAYLOADS_MAX_LENGTH");
+ if (val == null || val.trim().length() == 0) {
+ payloadsMaxLength = PAYLOADS_MAX_LENGTH;
+ } else {
+ try {
+ payloadsMaxLength = Integer.parseInt(val);
+ } catch (NumberFormatException ex) {
Review comment:
We need to add a log to specify the error and fallback action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang merged pull request #641: [SCB-1811]
Configure PAYLOADS_MAX_LENGTH parameter from os environment
Posted by GitBox <gi...@apache.org>.
WillemJiang merged pull request #641: [SCB-1811] Configure PAYLOADS_MAX_LENGTH parameter from os environment
URL: https://github.com/apache/servicecomb-pack/pull/641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services