You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/28 10:53:15 UTC
[GitHub] [hbase] virajjasani opened a new pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
virajjasani opened a new pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222
… with builder pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274937
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
##########
@@ -72,14 +70,17 @@ public void testDuplicateVersions() throws IOException {
byte[] familyBytes = Bytes.toBytes("Family");
TableName table = TableName.valueOf(name.getMethodName());
- HColumnDescriptor hcd =
- new HColumnDescriptor(familyBytes).setMaxVersions(1000);
- hcd.setMaxVersions(3);
- HTableDescriptor htd = new HTableDescriptor(table);
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(familyBytes)
+ .setMaxVersions(1000);
+ familyDescriptor.setMaxVersions(3);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273988
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionBase.java
##########
@@ -94,22 +96,22 @@ public TestMobCompactionBase() {
@Before
public void setUp() throws Exception {
HTU = new HBaseTestingUtility();
- hdt = HTU.createTableDescriptor(TableName.valueOf(getClass().getName()));
+ tableDescriptor = HTU.createModifyableTableDescriptor(getClass().getName());
conf = HTU.getConfiguration();
initConf();
HTU.startMiniCluster();
admin = HTU.getAdmin();
cleanerChore = new MobFileCleanerChore();
- hcd = new HColumnDescriptor(fam);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobLen);
- hcd.setMaxVersions(1);
- hdt.addFamily(hcd);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281197
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -2806,15 +2804,18 @@ public void testGetWithFilter() throws IOException, InterruptedException {
byte[] value2 = Bytes.toBytes("value2");
final int maxVersions = 3;
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setMaxVersions(maxVersions);
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf("testFilterAndColumnTracker"));
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setMaxVersions(maxVersions);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385962431
##########
File path: hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java
##########
@@ -105,15 +107,13 @@ public void TestIncBackupRestore() throws Exception {
Assert.assertEquals(HBaseTestingUtility.countRows(t1),
NB_ROWS_IN_BATCH + ADD_ROWS + NB_ROWS_FAM3);
LOG.debug("written " + ADD_ROWS + " rows to " + table1);
-
Review comment:
Why do you remove the empty lines? Because of the method length? I think they help increase the readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386257221
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -203,6 +230,38 @@ public static void add(HTableDescriptor desc,
updateLatestPriority(desc, priority);
}
+ /**
+ * Add configuration-less constraints to the table.
+ * <p>
+ * This will overwrite any configuration associated with the previous
+ * constraint of the same class.
+ * <p>
+ * Each constraint, when added to the table, will have a specific priority,
+ * dictating the order in which the {@link Constraint} will be run. A
+ * {@link Constraint} earlier in the list will be run before those later in
+ * the list. The same logic applies between two Constraints over time (earlier
+ * added is run first on the regionserver).
+ *
+ * @param tableDescriptor TableDescriptorBuilder.ModifyableTableDescriptor
Review comment:
Ah, then we're running into the Javadoc bug we had a few times already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani merged pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281746
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestNewVersionBehaviorFromClientSide.java
##########
@@ -77,12 +77,14 @@ public static void setDownAfterClass() throws Exception {
private Table createTable() throws IOException {
TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor table = new HTableDescriptor(tableName);
- HColumnDescriptor fam = new HColumnDescriptor(FAMILY);
- fam.setNewVersionBehavior(true);
- fam.setMaxVersions(3);
- table.addFamily(fam);
- TEST_UTIL.getAdmin().createTable(table);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(FAMILY);
+ familyDescriptor.setNewVersionBehavior(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385977158
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -203,6 +230,38 @@ public static void add(HTableDescriptor desc,
updateLatestPriority(desc, priority);
}
+ /**
+ * Add configuration-less constraints to the table.
+ * <p>
+ * This will overwrite any configuration associated with the previous
+ * constraint of the same class.
+ * <p>
+ * Each constraint, when added to the table, will have a specific priority,
+ * dictating the order in which the {@link Constraint} will be run. A
+ * {@link Constraint} earlier in the list will be run before those later in
+ * the list. The same logic applies between two Constraints over time (earlier
+ * added is run first on the regionserver).
+ *
+ * @param tableDescriptor TableDescriptorBuilder.ModifyableTableDescriptor
Review comment:
Use a Javadoc link for `TableDescriptorBuilder.ModifyableTableDescriptor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386118898
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
##########
@@ -210,18 +211,21 @@ public void stop(CoprocessorEnvironment env) throws IOException {
public void postStartMaster(ObserverContext<MasterCoprocessorEnvironment> ctx) throws IOException {
// Need to create the new system table for labels here
if (!MetaTableAccessor.tableExists(ctx.getEnvironment().getConnection(), LABELS_TABLE_NAME)) {
- HTableDescriptor labelsTable = new HTableDescriptor(LABELS_TABLE_NAME);
- HColumnDescriptor labelsColumn = new HColumnDescriptor(LABELS_TABLE_FAMILY);
- labelsColumn.setBloomFilterType(BloomType.NONE);
- labelsColumn.setBlockCacheEnabled(false); // We will cache all the labels. No need of normal
- // table block cache.
- labelsTable.addFamily(labelsColumn);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(LABELS_TABLE_NAME);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(LABELS_TABLE_FAMILY);
+ familyDescriptor.setBloomFilterType(BloomType.NONE);
+ familyDescriptor.setBlockCacheEnabled(false);
+ // We will cache all the labels. No need of normal
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592688421
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 134 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 34s | master passed |
| +1 :green_heart: | compile | 4m 43s | master passed |
| +1 :green_heart: | checkstyle | 4m 35s | master passed |
| +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 18s | master passed |
| +0 :ok: | spotbugs | 1m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 10m 35s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | compile | 4m 45s | the patch passed |
| +1 :green_heart: | javac | 4m 45s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 33s | hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98) |
| +1 :green_heart: | checkstyle | 1m 31s | hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973) |
| +1 :green_heart: | checkstyle | 0m 22s | hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66) |
| +1 :green_heart: | checkstyle | 0m 38s | The patch passed checkstyle in hbase-thrift |
| +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-endpoint |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in hbase-backup |
| +1 :green_heart: | checkstyle | 0m 21s | hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129) |
| +1 :green_heart: | checkstyle | 0m 21s | The patch passed checkstyle in hbase-rest |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-shaded-client-project |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 12s | the patch passed |
| +1 :green_heart: | findbugs | 11m 43s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 54s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 62m 34s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 6m 51s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 2m 27s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 27s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 7m 29s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 16s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 2m 47s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-shaded-client-project in the patch passed. |
| +1 :green_heart: | asflicense | 4m 58s | The patch does not generate ASF License warnings. |
| | | 188m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1222 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 16301fb45f9b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh |
| git revision | master / b24ea32b3b |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/testReport/ |
| Max. process+thread count | 9592 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281415
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -6056,17 +6078,20 @@ public void testCellTTLs() throws IOException {
final byte[] q3 = Bytes.toBytes("q3");
final byte[] q4 = Bytes.toBytes("q4");
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(name.getMethodName()));
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setTimeToLive(10); // 10 seconds
- htd.addFamily(hcd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf(name.getMethodName()));
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setTimeToLive(10); // 10 seconds
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273885
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestDefaultMobStoreFlusher.java
##########
@@ -70,34 +70,41 @@ public static void tearDownAfterClass() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
- @Test
- public void testFlushNonMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ @Test
+ public void testFlushNonMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
- testFlushFile(desc);
- }
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(4);
+ tableDescriptor.setColumnFamily(familyDescriptor);
- @Test
- public void testFlushMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(3L);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
-
- testFlushFile(desc);
- }
+ testFlushFile(tableDescriptor);
+ }
+
+ @Test
+ public void testFlushMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor hcd =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ hcd.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386118740
##########
File path: hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java
##########
@@ -105,15 +107,13 @@ public void TestIncBackupRestore() throws Exception {
Assert.assertEquals(HBaseTestingUtility.countRows(t1),
NB_ROWS_IN_BATCH + ADD_ROWS + NB_ROWS_FAM3);
LOG.debug("written " + ADD_ROWS + " rows to " + table1);
-
Review comment:
Is this fine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273885
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestDefaultMobStoreFlusher.java
##########
@@ -70,34 +70,41 @@ public static void tearDownAfterClass() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
- @Test
- public void testFlushNonMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ @Test
+ public void testFlushNonMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
- testFlushFile(desc);
- }
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(4);
+ tableDescriptor.setColumnFamily(familyDescriptor);
- @Test
- public void testFlushMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(3L);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
-
- testFlushFile(desc);
- }
+ testFlushFile(tableDescriptor);
+ }
+
+ @Test
+ public void testFlushMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor hcd =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ hcd.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281415
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -6056,17 +6078,20 @@ public void testCellTTLs() throws IOException {
final byte[] q3 = Bytes.toBytes("q3");
final byte[] q4 = Bytes.toBytes("q4");
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(name.getMethodName()));
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setTimeToLive(10); // 10 seconds
- htd.addFamily(hcd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf(name.getMethodName()));
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setTimeToLive(10); // 10 seconds
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385987738
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionRegularMode.java
##########
@@ -57,6 +57,13 @@
public TestMobCompactionRegularMode() {
}
+ @Override
+ protected void mobCompact(Admin admin2, TableDescriptor tableDescriptor,
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274486
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreCompaction.java
##########
@@ -116,18 +113,17 @@ private void init(Configuration conf, long mobThreshold) throws Exception {
HBaseTestingUtility UTIL = new HBaseTestingUtility(conf);
compactionThreshold = conf.getInt("hbase.hstore.compactionThreshold", 3);
- htd = UTIL.createTableDescriptor(TableName.valueOf(name.getMethodName()),
- HColumnDescriptor.DEFAULT_MIN_VERSIONS, 3, HConstants.FOREVER,
- HColumnDescriptor.DEFAULT_KEEP_DELETED);
- hcd = new HColumnDescriptor(COLUMN_FAMILY);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobThreshold);
- hcd.setMaxVersions(1);
- htd.modifyFamily(hcd);
-
- RegionInfo regionInfo = RegionInfoBuilder.newBuilder(htd.getTableName()).build();
- region = HBaseTestingUtility
- .createRegionAndWAL(regionInfo, UTIL.getDataTestDir(), conf, htd, new MobFileCache(conf));
+ tableDescriptor = UTIL.createModifyableTableDescriptor(name.getMethodName());
+ familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(COLUMN_FAMILY);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386006041
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -203,6 +230,38 @@ public static void add(HTableDescriptor desc,
updateLatestPriority(desc, priority);
}
+ /**
+ * Add configuration-less constraints to the table.
+ * <p>
+ * This will overwrite any configuration associated with the previous
+ * constraint of the same class.
+ * <p>
+ * Each constraint, when added to the table, will have a specific priority,
+ * dictating the order in which the {@link Constraint} will be run. A
+ * {@link Constraint} earlier in the list will be run before those later in
+ * the list. The same logic applies between two Constraints over time (earlier
+ * added is run first on the regionserver).
+ *
+ * @param tableDescriptor TableDescriptorBuilder.ModifyableTableDescriptor
Review comment:
Unfortunately, it's not working somehow. This is the error I get: `warning - Tag @link: reference not found: TableDescriptorBuilder.ModifyableTableDescriptor`
FYI https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385982897
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
##########
@@ -210,18 +211,21 @@ public void stop(CoprocessorEnvironment env) throws IOException {
public void postStartMaster(ObserverContext<MasterCoprocessorEnvironment> ctx) throws IOException {
// Need to create the new system table for labels here
if (!MetaTableAccessor.tableExists(ctx.getEnvironment().getConnection(), LABELS_TABLE_NAME)) {
- HTableDescriptor labelsTable = new HTableDescriptor(LABELS_TABLE_NAME);
- HColumnDescriptor labelsColumn = new HColumnDescriptor(LABELS_TABLE_FAMILY);
- labelsColumn.setBloomFilterType(BloomType.NONE);
- labelsColumn.setBlockCacheEnabled(false); // We will cache all the labels. No need of normal
- // table block cache.
- labelsTable.addFamily(labelsColumn);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(LABELS_TABLE_NAME);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(LABELS_TABLE_FAMILY);
+ familyDescriptor.setBloomFilterType(BloomType.NONE);
+ familyDescriptor.setBlockCacheEnabled(false);
+ // We will cache all the labels. No need of normal
Review comment:
The comment should be above the line with setting the cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273988
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionBase.java
##########
@@ -94,22 +96,22 @@ public TestMobCompactionBase() {
@Before
public void setUp() throws Exception {
HTU = new HBaseTestingUtility();
- hdt = HTU.createTableDescriptor(TableName.valueOf(getClass().getName()));
+ tableDescriptor = HTU.createModifyableTableDescriptor(getClass().getName());
conf = HTU.getConfiguration();
initConf();
HTU.startMiniCluster();
admin = HTU.getAdmin();
cleanerChore = new MobFileCleanerChore();
- hcd = new HColumnDescriptor(fam);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobLen);
- hcd.setMaxVersions(1);
- hdt.addFamily(hcd);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385977232
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -203,6 +230,38 @@ public static void add(HTableDescriptor desc,
updateLatestPriority(desc, priority);
}
+ /**
+ * Add configuration-less constraints to the table.
+ * <p>
+ * This will overwrite any configuration associated with the previous
+ * constraint of the same class.
+ * <p>
+ * Each constraint, when added to the table, will have a specific priority,
+ * dictating the order in which the {@link Constraint} will be run. A
+ * {@link Constraint} earlier in the list will be run before those later in
+ * the list. The same logic applies between two Constraints over time (earlier
+ * added is run first on the regionserver).
+ *
+ * @param tableDescriptor TableDescriptorBuilder.ModifyableTableDescriptor
+ * to add {@link Constraint Constraints}
Review comment:
Contains a link to `Constraints` twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281746
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestNewVersionBehaviorFromClientSide.java
##########
@@ -77,12 +77,14 @@ public static void setDownAfterClass() throws Exception {
private Table createTable() throws IOException {
TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor table = new HTableDescriptor(tableName);
- HColumnDescriptor fam = new HColumnDescriptor(FAMILY);
- fam.setNewVersionBehavior(true);
- fam.setMaxVersions(3);
- table.addFamily(fam);
- TEST_UTIL.getAdmin().createTable(table);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(FAMILY);
+ familyDescriptor.setNewVersionBehavior(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273681
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/MobStressToolRunner.java
##########
@@ -90,20 +90,21 @@ public void init(Configuration conf, long numRows) throws IOException {
this.count = numRows;
initConf();
printConf();
- hdt = new HTableDescriptor(TableName.valueOf("testMobCompactTable"));
+ tableDescriptor = new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf("testMobCompactTable"));
Connection conn = ConnectionFactory.createConnection(this.conf);
this.admin = conn.getAdmin();
- this.hcd = new HColumnDescriptor(fam);
- this.hcd.setMobEnabled(true);
- this.hcd.setMobThreshold(mobLen);
- this.hcd.setMaxVersions(1);
- this.hdt.addFamily(hcd);
- if (admin.tableExists(hdt.getTableName())) {
- admin.disableTable(hdt.getTableName());
- admin.deleteTable(hdt.getTableName());
+ this.familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ this.familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386282004
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
##########
@@ -629,12 +636,17 @@ public static void main(String[] args) throws Exception {
int numRegions = Integer.parseInt(args[0]);
long numRows = Long.parseLong(args[1]);
- HTableDescriptor htd = new HTableDescriptor(TABLENAME);
- htd.setMaxFileSize(10L * 1024 * 1024 * 1024);
- htd.setValue(HTableDescriptor.SPLIT_POLICY, ConstantSizeRegionSplitPolicy.class.getName());
- htd.addFamily(new HColumnDescriptor(FAMILY1));
- htd.addFamily(new HColumnDescriptor(FAMILY2));
- htd.addFamily(new HColumnDescriptor(FAMILY3));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TABLENAME);
+ tableDescriptor.setMaxFileSize(10L * 1024 * 1024 * 1024);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385977364
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -337,6 +396,13 @@ private static void writeConstraint(HTableDescriptor desc, String key,
desc.setValue(key, serializeConfiguration(conf));
}
+ private static void writeConstraint(
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor, String key,
+ Configuration conf) throws IOException {
Review comment:
NIT: Should have the same indentation as the line before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386275633
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java
##########
@@ -111,10 +112,12 @@ public void testThreadPoolSizeTuning() throws Exception {
Configuration conf = TEST_UTIL.getConfiguration();
Connection conn = ConnectionFactory.createConnection(conf);
try {
- HTableDescriptor htd = new HTableDescriptor(tableName);
- htd.addFamily(new HColumnDescriptor(family));
- htd.setCompactionEnabled(false);
- TEST_UTIL.getAdmin().createTable(htd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ tableDescriptor.setColumnFamily(
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family));
+ tableDescriptor.setCompactionEnabled(false);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386280781
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
##########
@@ -127,19 +126,18 @@ public TestCompaction() {
@Before
public void setUp() throws Exception {
- this.htd = UTIL.createTableDescriptor(TableName.valueOf(name.getMethodName()),
- HColumnDescriptor.DEFAULT_MIN_VERSIONS, 3, HConstants.FOREVER,
- HColumnDescriptor.DEFAULT_KEEP_DELETED);
+ this.tableDescriptor = UTIL.createModifyableTableDescriptor(name.getMethodName());
if (name.getMethodName().equals("testCompactionSeqId")) {
UTIL.getConfiguration().set("hbase.hstore.compaction.kv.max", "10");
UTIL.getConfiguration().set(
DefaultStoreEngine.DEFAULT_COMPACTOR_CLASS_KEY,
DummyCompactor.class.getName());
- HColumnDescriptor hcd = new HColumnDescriptor(FAMILY);
- hcd.setMaxVersions(65536);
- this.htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(FAMILY);
+ familyDescriptor.setMaxVersions(65536);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385963635
##########
File path: hbase-client/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
##########
@@ -309,41 +312,52 @@ public void testClassMethodsAreBuilderStyle() {
@Test
public void testModifyFamily() {
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(name.getMethodName()));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf(name.getMethodName()));
byte[] familyName = Bytes.toBytes("cf");
- HColumnDescriptor hcd = new HColumnDescriptor(familyName);
- hcd.setBlocksize(1000);
- hcd.setDFSReplication((short) 3);
- htd.addFamily(hcd);
- assertEquals(1000, htd.getFamily(familyName).getBlocksize());
- assertEquals(3, htd.getFamily(familyName).getDFSReplication());
- hcd = new HColumnDescriptor(familyName);
- hcd.setBlocksize(2000);
- hcd.setDFSReplication((short) 1);
- htd.modifyFamily(hcd);
- assertEquals(2000, htd.getFamily(familyName).getBlocksize());
- assertEquals(1, htd.getFamily(familyName).getDFSReplication());
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(familyName);
+ familyDescriptor.setBlocksize(1000);
Review comment:
Better would be to use the fluent API, also for other occurrences in this test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386005531
##########
File path: hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java
##########
@@ -105,15 +107,13 @@ public void TestIncBackupRestore() throws Exception {
Assert.assertEquals(HBaseTestingUtility.countRows(t1),
NB_ROWS_IN_BATCH + ADD_ROWS + NB_ROWS_FAM3);
LOG.debug("written " + ADD_ROWS + " rows to " + table1);
-
Review comment:
Oh this is because, checkstyle complained about >150 lines in this method. I didn't want to remove it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273817
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestDefaultMobStoreFlusher.java
##########
@@ -70,34 +70,41 @@ public static void tearDownAfterClass() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
- @Test
- public void testFlushNonMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ @Test
+ public void testFlushNonMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
- testFlushFile(desc);
- }
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(4);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281578
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java
##########
@@ -113,13 +111,15 @@ public void testJoinedScanners() throws Exception {
byte[][] families = {cf_essential, cf_joined};
final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
for (byte[] family : families) {
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setDataBlockEncoding(blockEncoding);
- desc.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setDataBlockEncoding(blockEncoding);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386282004
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
##########
@@ -629,12 +636,17 @@ public static void main(String[] args) throws Exception {
int numRegions = Integer.parseInt(args[0]);
long numRows = Long.parseLong(args[1]);
- HTableDescriptor htd = new HTableDescriptor(TABLENAME);
- htd.setMaxFileSize(10L * 1024 * 1024 * 1024);
- htd.setValue(HTableDescriptor.SPLIT_POLICY, ConstantSizeRegionSplitPolicy.class.getName());
- htd.addFamily(new HColumnDescriptor(FAMILY1));
- htd.addFamily(new HColumnDescriptor(FAMILY2));
- htd.addFamily(new HColumnDescriptor(FAMILY3));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TABLENAME);
+ tableDescriptor.setMaxFileSize(10L * 1024 * 1024 * 1024);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-593364692
Thanks for the review @HorizonNet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281919
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
##########
@@ -558,11 +561,15 @@ public void testCompareStoreFileCount() throws Exception {
conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY,
ConstantSizeRegionSplitPolicy.class.getName());
- HTableDescriptor htd = new HTableDescriptor(TABLENAME);
- htd.setCompactionEnabled(false);
- htd.addFamily(new HColumnDescriptor(FAMILY1));
- htd.addFamily(new HColumnDescriptor(FAMILY2));
- htd.addFamily(new HColumnDescriptor(FAMILY3));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TABLENAME);
+ tableDescriptor.setCompactionEnabled(false);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281919
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
##########
@@ -558,11 +561,15 @@ public void testCompareStoreFileCount() throws Exception {
conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY,
ConstantSizeRegionSplitPolicy.class.getName());
- HTableDescriptor htd = new HTableDescriptor(TABLENAME);
- htd.setCompactionEnabled(false);
- htd.addFamily(new HColumnDescriptor(FAMILY1));
- htd.addFamily(new HColumnDescriptor(FAMILY2));
- htd.addFamily(new HColumnDescriptor(FAMILY3));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TABLENAME);
+ tableDescriptor.setCompactionEnabled(false);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385987715
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionOptRegionBatchMode.java
##########
@@ -76,6 +76,13 @@ protected void initConf() {
conf.setLong(MobConstants.MOB_COMPACTION_MAX_FILE_SIZE_KEY, 1000000);
}
+ @Override
+ protected void mobCompact(Admin admin2, TableDescriptor tableDescriptor,
Review comment:
Why `admin2` as the parameter name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385982994
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
##########
@@ -151,23 +154,23 @@ protected Path getUnitTestdir(String testName) {
/**
* You must call close on the returned region and then close on the log file it created. Do
* {@link HBaseTestingUtility#closeRegionAndWAL(HRegion)} to close both the region and the WAL.
- * @param desc
- * @param startKey
- * @param endKey
+ * @param tableDescriptor TableDescriptor
+ * @param startKey Start Key
+ * @param endKey End Key
* @return An {@link HRegion}
- * @throws IOException
+ * @throws IOException If thrown by createNewHRegion
Review comment:
Use a link for `createNewHRegion`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273817
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestDefaultMobStoreFlusher.java
##########
@@ -70,34 +70,41 @@ public static void tearDownAfterClass() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
- @Test
- public void testFlushNonMobFile() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ @Test
+ public void testFlushNonMobFile() throws Exception {
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
- testFlushFile(desc);
- }
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(4);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274396
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java
##########
@@ -87,24 +87,23 @@
public TestMobFileCleanerChore() {
}
-
@Before
public void setUp() throws Exception {
HTU = new HBaseTestingUtility();
- hdt = HTU.createTableDescriptor(TableName.valueOf("testMobCompactTable"));
+ tableDescriptor = HTU.createModifyableTableDescriptor("testMobCompactTable");
conf = HTU.getConfiguration();
initConf();
HTU.startMiniCluster();
admin = HTU.getAdmin();
chore = new MobFileCleanerChore();
- hcd = new HColumnDescriptor(fam);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobLen);
- hcd.setMaxVersions(1);
- hdt.addFamily(hcd);
- table = HTU.createTable(hdt, null);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274486
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreCompaction.java
##########
@@ -116,18 +113,17 @@ private void init(Configuration conf, long mobThreshold) throws Exception {
HBaseTestingUtility UTIL = new HBaseTestingUtility(conf);
compactionThreshold = conf.getInt("hbase.hstore.compactionThreshold", 3);
- htd = UTIL.createTableDescriptor(TableName.valueOf(name.getMethodName()),
- HColumnDescriptor.DEFAULT_MIN_VERSIONS, 3, HConstants.FOREVER,
- HColumnDescriptor.DEFAULT_KEEP_DELETED);
- hcd = new HColumnDescriptor(COLUMN_FAMILY);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobThreshold);
- hcd.setMaxVersions(1);
- htd.modifyFamily(hcd);
-
- RegionInfo regionInfo = RegionInfoBuilder.newBuilder(htd.getTableName()).build();
- region = HBaseTestingUtility
- .createRegionAndWAL(regionInfo, UTIL.getDataTestDir(), conf, htd, new MobFileCache(conf));
+ tableDescriptor = UTIL.createModifyableTableDescriptor(name.getMethodName());
+ familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(COLUMN_FAMILY);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281578
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java
##########
@@ -113,13 +111,15 @@ public void testJoinedScanners() throws Exception {
byte[][] families = {cf_essential, cf_joined};
final TableName tableName = TableName.valueOf(name.getMethodName());
- HTableDescriptor desc = new HTableDescriptor(tableName);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
for (byte[] family : families) {
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setDataBlockEncoding(blockEncoding);
- desc.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setDataBlockEncoding(blockEncoding);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386275633
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java
##########
@@ -111,10 +112,12 @@ public void testThreadPoolSizeTuning() throws Exception {
Configuration conf = TEST_UTIL.getConfiguration();
Connection conn = ConnectionFactory.createConnection(conf);
try {
- HTableDescriptor htd = new HTableDescriptor(tableName);
- htd.addFamily(new HColumnDescriptor(family));
- htd.setCompactionEnabled(false);
- TEST_UTIL.getAdmin().createTable(htd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ tableDescriptor.setColumnFamily(
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family));
+ tableDescriptor.setCompactionEnabled(false);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385989825
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
##########
@@ -184,14 +186,16 @@ public void testFlushAndCompactionWithoutTags() throws Exception {
byte[] row2 = Bytes.toBytes("rowc");
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor colDesc = new HColumnDescriptor(fam);
- colDesc.setBlockCacheEnabled(true);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setBlockCacheEnabled(true);
// colDesc.setDataBlockEncoding(DataBlockEncoding.NONE);
Review comment:
Also remove the commented out lines when already on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274396
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java
##########
@@ -87,24 +87,23 @@
public TestMobFileCleanerChore() {
}
-
@Before
public void setUp() throws Exception {
HTU = new HBaseTestingUtility();
- hdt = HTU.createTableDescriptor(TableName.valueOf("testMobCompactTable"));
+ tableDescriptor = HTU.createModifyableTableDescriptor("testMobCompactTable");
conf = HTU.getConfiguration();
initConf();
HTU.startMiniCluster();
admin = HTU.getAdmin();
chore = new MobFileCleanerChore();
- hcd = new HColumnDescriptor(fam);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(mobLen);
- hcd.setMaxVersions(1);
- hdt.addFamily(hcd);
- table = HTU.createTable(hdt, null);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-593219898
@HorizonNet Does it look good to you with latest QA results?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274228
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobDataBlockEncoding.java
##########
@@ -69,17 +70,19 @@ public static void tearDownAfterClass() throws Exception {
public void setUp(long threshold, String TN, DataBlockEncoding encoding)
throws Exception {
- desc = new HTableDescriptor(TableName.valueOf(TN));
- hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(threshold);
- hcd.setMaxVersions(4);
- hcd.setDataBlockEncoding(encoding);
- desc.addFamily(hcd);
+ tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TableName.valueOf(TN));
+ columnFamilyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ columnFamilyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274592
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreScanner.java
##########
@@ -99,14 +99,14 @@ public static void tearDownAfterClass() throws Exception {
public void setUp(long threshold, TableName tn) throws Exception {
conf = TEST_UTIL.getConfiguration();
fs = FileSystem.get(conf);
- desc = new HTableDescriptor(tn);
- hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(threshold);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ tableDescriptor = new TableDescriptorBuilder.ModifyableTableDescriptor(tn);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274937
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
##########
@@ -72,14 +70,17 @@ public void testDuplicateVersions() throws IOException {
byte[] familyBytes = Bytes.toBytes("Family");
TableName table = TableName.valueOf(name.getMethodName());
- HColumnDescriptor hcd =
- new HColumnDescriptor(familyBytes).setMaxVersions(1000);
- hcd.setMaxVersions(3);
- HTableDescriptor htd = new HTableDescriptor(table);
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(familyBytes)
+ .setMaxVersions(1000);
+ familyDescriptor.setMaxVersions(3);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386273681
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/MobStressToolRunner.java
##########
@@ -90,20 +90,21 @@ public void init(Configuration conf, long numRows) throws IOException {
this.count = numRows;
initConf();
printConf();
- hdt = new HTableDescriptor(TableName.valueOf("testMobCompactTable"));
+ tableDescriptor = new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf("testMobCompactTable"));
Connection conn = ConnectionFactory.createConnection(this.conf);
this.admin = conn.getAdmin();
- this.hcd = new HColumnDescriptor(fam);
- this.hcd.setMobEnabled(true);
- this.hcd.setMobThreshold(mobLen);
- this.hcd.setMaxVersions(1);
- this.hdt.addFamily(hcd);
- if (admin.tableExists(hdt.getTableName())) {
- admin.disableTable(hdt.getTableName());
- admin.deleteTable(hdt.getTableName());
+ this.familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ this.familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274757
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
##########
@@ -301,15 +299,18 @@ private void initHRegion (byte [] tableName, String callingMethod,
private void initHRegion (byte [] tableName, String callingMethod, int [] maxVersions,
byte[] ... families)
throws IOException {
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(tableName));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TableName.valueOf(tableName));
+
int i=0;
for(byte [] family : families) {
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(maxVersions != null ? maxVersions[i++] : 1);
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(maxVersions != null ? maxVersions[i++] : 1);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-593110839
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 134 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 48s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 21s | master passed |
| +1 :green_heart: | compile | 4m 42s | master passed |
| +1 :green_heart: | checkstyle | 4m 39s | master passed |
| +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 25s | master passed |
| +0 :ok: | spotbugs | 1m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 11m 33s | master passed |
| -0 :warning: | patch | 2m 55s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 32s | the patch passed |
| +1 :green_heart: | compile | 4m 59s | the patch passed |
| +1 :green_heart: | javac | 4m 59s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 35s | hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98) |
| +1 :green_heart: | checkstyle | 1m 34s | hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973) |
| +1 :green_heart: | checkstyle | 0m 22s | hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66) |
| +1 :green_heart: | checkstyle | 0m 37s | The patch passed checkstyle in hbase-thrift |
| +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-endpoint |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in hbase-backup |
| +1 :green_heart: | checkstyle | 0m 21s | hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129) |
| +1 :green_heart: | checkstyle | 0m 21s | The patch passed checkstyle in hbase-rest |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-shaded-client-project |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 53s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 17s | the patch passed |
| +1 :green_heart: | findbugs | 11m 47s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 56s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 61m 3s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 6m 50s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 2m 25s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 25s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 7m 30s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 10s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 2m 46s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 7s | hbase-shaded-client-project in the patch passed. |
| +1 :green_heart: | asflicense | 5m 0s | The patch does not generate ASF License warnings. |
| | | 188m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1222 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1bc591059806 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh |
| git revision | master / 48a3ccf523 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/testReport/ |
| Max. process+thread count | 9727 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani removed a comment on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani removed a comment on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592984021
@HorizonNet I have addressed comments. Could you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274757
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
##########
@@ -301,15 +299,18 @@ private void initHRegion (byte [] tableName, String callingMethod,
private void initHRegion (byte [] tableName, String callingMethod, int [] maxVersions,
byte[] ... families)
throws IOException {
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(tableName));
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TableName.valueOf(tableName));
+
int i=0;
for(byte [] family : families) {
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(maxVersions != null ? maxVersions[i++] : 1);
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(maxVersions != null ? maxVersions[i++] : 1);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592932803
Test failures in the latest QA results are not relevant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386280781
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
##########
@@ -127,19 +126,18 @@ public TestCompaction() {
@Before
public void setUp() throws Exception {
- this.htd = UTIL.createTableDescriptor(TableName.valueOf(name.getMethodName()),
- HColumnDescriptor.DEFAULT_MIN_VERSIONS, 3, HConstants.FOREVER,
- HColumnDescriptor.DEFAULT_KEEP_DELETED);
+ this.tableDescriptor = UTIL.createModifyableTableDescriptor(name.getMethodName());
if (name.getMethodName().equals("testCompactionSeqId")) {
UTIL.getConfiguration().set("hbase.hstore.compaction.kv.max", "10");
UTIL.getConfiguration().set(
DefaultStoreEngine.DEFAULT_COMPACTOR_CLASS_KEY,
DummyCompactor.class.getName());
- HColumnDescriptor hcd = new HColumnDescriptor(FAMILY);
- hcd.setMaxVersions(65536);
- this.htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(FAMILY);
+ familyDescriptor.setMaxVersions(65536);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385977261
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -203,6 +230,38 @@ public static void add(HTableDescriptor desc,
updateLatestPriority(desc, priority);
}
+ /**
+ * Add configuration-less constraints to the table.
+ * <p>
+ * This will overwrite any configuration associated with the previous
+ * constraint of the same class.
+ * <p>
+ * Each constraint, when added to the table, will have a specific priority,
+ * dictating the order in which the {@link Constraint} will be run. A
+ * {@link Constraint} earlier in the list will be run before those later in
+ * the list. The same logic applies between two Constraints over time (earlier
+ * added is run first on the regionserver).
+ *
+ * @param tableDescriptor TableDescriptorBuilder.ModifyableTableDescriptor
+ * to add {@link Constraint Constraints}
+ * @param constraints {@link Constraint Constraints} to add. All constraints are
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281197
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -2806,15 +2804,18 @@ public void testGetWithFilter() throws IOException, InterruptedException {
byte[] value2 = Bytes.toBytes("value2");
final int maxVersions = 3;
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setMaxVersions(maxVersions);
- HTableDescriptor htd = new HTableDescriptor(TableName.valueOf("testFilterAndColumnTracker"));
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setMaxVersions(maxVersions);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592984021
@HorizonNet I have addressed comments. Could you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274592
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreScanner.java
##########
@@ -99,14 +99,14 @@ public static void tearDownAfterClass() throws Exception {
public void setUp(long threshold, TableName tn) throws Exception {
conf = TEST_UTIL.getConfiguration();
fs = FileSystem.get(conf);
- desc = new HTableDescriptor(tn);
- hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(threshold);
- hcd.setMaxVersions(4);
- desc.addFamily(hcd);
+ tableDescriptor = new TableDescriptorBuilder.ModifyableTableDescriptor(tn);
+ familyDescriptor = new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274228
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobDataBlockEncoding.java
##########
@@ -69,17 +70,19 @@ public static void tearDownAfterClass() throws Exception {
public void setUp(long threshold, String TN, DataBlockEncoding encoding)
throws Exception {
- desc = new HTableDescriptor(TableName.valueOf(TN));
- hcd = new HColumnDescriptor(family);
- hcd.setMobEnabled(true);
- hcd.setMobThreshold(threshold);
- hcd.setMaxVersions(4);
- hcd.setDataBlockEncoding(encoding);
- desc.addFamily(hcd);
+ tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TableName.valueOf(TN));
+ columnFamilyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ columnFamilyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592537376
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 3s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 134 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 21s | master passed |
| +1 :green_heart: | compile | 4m 41s | master passed |
| +1 :green_heart: | checkstyle | 4m 24s | master passed |
| +1 :green_heart: | shadedjars | 4m 43s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 13s | master passed |
| +0 :ok: | spotbugs | 2m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 12m 26s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 44s | the patch passed |
| +1 :green_heart: | compile | 6m 50s | the patch passed |
| +1 :green_heart: | javac | 6m 50s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 45s | hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98) |
| -1 :x: | checkstyle | 2m 18s | hbase-server: The patch generated 28 new + 947 unchanged - 26 fixed = 975 total (was 973) |
| +1 :green_heart: | checkstyle | 0m 28s | hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66) |
| -1 :x: | checkstyle | 0m 56s | hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | checkstyle | 0m 19s | The patch passed checkstyle in hbase-endpoint |
| -1 :x: | checkstyle | 0m 24s | hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | checkstyle | 0m 26s | hbase-it: The patch generated 1 new + 128 unchanged - 1 fixed = 129 total (was 129) |
| -1 :x: | checkstyle | 0m 25s | hbase-rest: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108) |
| +1 :green_heart: | checkstyle | 0m 17s | The patch passed checkstyle in hbase-shaded-client-project |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 24m 56s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 37s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | findbugs | 11m 52s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 56s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 62m 7s | hbase-server in the patch passed. |
| -1 :x: | unit | 6m 32s | hbase-mapreduce in the patch failed. |
| +1 :green_heart: | unit | 2m 26s | hbase-thrift in the patch passed. |
| -1 :x: | unit | 3m 29s | hbase-endpoint in the patch failed. |
| +1 :green_heart: | unit | 7m 29s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 2m 47s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-shaded-client-project in the patch passed. |
| +1 :green_heart: | asflicense | 5m 0s | The patch does not generate ASF License warnings. |
| | | 209m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.mapreduce.TestSyncTable |
| | hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1222 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b4f22f2eacc2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh |
| git revision | master / 3c3aae9a2f |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-thrift.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-backup.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-it.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/patch-unit-hbase-mapreduce.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/patch-unit-hbase-endpoint.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/testReport/ |
| Max. process+thread count | 9653 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#issuecomment-592931171
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 3s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 134 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 22s | master passed |
| +1 :green_heart: | compile | 4m 44s | master passed |
| +1 :green_heart: | checkstyle | 4m 34s | master passed |
| +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 20s | master passed |
| +0 :ok: | spotbugs | 1m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 10m 37s | master passed |
| -0 :warning: | patch | 2m 42s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 8s | the patch passed |
| +1 :green_heart: | compile | 4m 53s | the patch passed |
| +1 :green_heart: | javac | 4m 53s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 32s | hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98) |
| +1 :green_heart: | checkstyle | 1m 33s | hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973) |
| +1 :green_heart: | checkstyle | 0m 22s | hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66) |
| +1 :green_heart: | checkstyle | 0m 44s | The patch passed checkstyle in hbase-thrift |
| +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-endpoint |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in hbase-backup |
| +1 :green_heart: | checkstyle | 0m 22s | hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129) |
| +1 :green_heart: | checkstyle | 0m 20s | The patch passed checkstyle in hbase-rest |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-shaded-client-project |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 18s | the patch passed |
| +1 :green_heart: | findbugs | 11m 47s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 56s | hbase-client in the patch passed. |
| -1 :x: | unit | 62m 12s | hbase-server in the patch failed. |
| -1 :x: | unit | 6m 50s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 14m 1s | hbase-thrift in the patch failed. |
| +1 :green_heart: | unit | 3m 26s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 7m 34s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 12s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 2m 46s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-shaded-client-project in the patch passed. |
| +1 :green_heart: | asflicense | 5m 3s | The patch does not generate ASF License warnings. |
| | | 199m 48s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.wal.TestWALSplit |
| | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToEmpty |
| | hadoop.hbase.thrift2.TestThriftHBaseServiceHandler |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1222 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d30e4b5d05cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh |
| git revision | master / a420f0482e |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-mapreduce.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-thrift.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/testReport/ |
| Max. process+thread count | 9555 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services