You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Daniel Kulp (JIRA)" <ji...@apache.org> on 2012/09/07 18:42:07 UTC

[jira] [Created] (HTTPASYNC-25) AsyncSchemeRegistry should be settable per-client instance

Daniel Kulp created HTTPASYNC-25:
------------------------------------

             Summary: AsyncSchemeRegistry should be settable per-client instance
                 Key: HTTPASYNC-25
                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-25
             Project: HttpComponents HttpAsyncClient
          Issue Type: Improvement
    Affects Versions: 4.0-beta2
            Reporter: Daniel Kulp
             Fix For: 4.0-beta3
         Attachments: HTTPASYNC-25.patch


For CXF, we need to be able to pass a specific SSLLayeringStrategy into the client on a per-client basis, not part of the ConnectionManager.   However, right now, the ManagedClientAsyncConnectionImpl class always uses the AsyncSchemeRegistry of the manager without consulting the registry already stored on the HttpContext.  With a couple of minor updates (patch supplied) we can get the CXF tests passing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPASYNC-25) AsyncSchemeRegistry should be settable per-client instance

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPASYNC-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452163#comment-13452163 ] 

Daniel Kulp commented on HTTPASYNC-25:
--------------------------------------


Your changes look great to me.  Thanks!
Dan
                
> AsyncSchemeRegistry should be settable per-client instance
> ----------------------------------------------------------
>
>                 Key: HTTPASYNC-25
>                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-25
>             Project: HttpComponents HttpAsyncClient
>          Issue Type: Improvement
>    Affects Versions: 4.0-beta2
>            Reporter: Daniel Kulp
>             Fix For: 4.0-beta3
>
>         Attachments: HTTPASYNC-25.patch
>
>
> For CXF, we need to be able to pass a specific SSLLayeringStrategy into the client on a per-client basis, not part of the ConnectionManager.   However, right now, the ManagedClientAsyncConnectionImpl class always uses the AsyncSchemeRegistry of the manager without consulting the registry already stored on the HttpContext.  With a couple of minor updates (patch supplied) we can get the CXF tests passing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPASYNC-25) AsyncSchemeRegistry should be settable per-client instance

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPASYNC-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp updated HTTPASYNC-25:
---------------------------------

    Attachment: HTTPASYNC-25.patch
    
> AsyncSchemeRegistry should be settable per-client instance
> ----------------------------------------------------------
>
>                 Key: HTTPASYNC-25
>                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-25
>             Project: HttpComponents HttpAsyncClient
>          Issue Type: Improvement
>    Affects Versions: 4.0-beta2
>            Reporter: Daniel Kulp
>             Fix For: 4.0-beta3
>
>         Attachments: HTTPASYNC-25.patch
>
>
> For CXF, we need to be able to pass a specific SSLLayeringStrategy into the client on a per-client basis, not part of the ConnectionManager.   However, right now, the ManagedClientAsyncConnectionImpl class always uses the AsyncSchemeRegistry of the manager without consulting the registry already stored on the HttpContext.  With a couple of minor updates (patch supplied) we can get the CXF tests passing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Resolved] (HTTPASYNC-25) AsyncSchemeRegistry should be settable per-client instance

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPASYNC-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPASYNC-25.
----------------------------------------

    Resolution: Fixed

Hi Daniel

I committed your patch with some minor changes [1]. Please review and let me know if those changes work for you.

Oleg

[1] http://svn.apache.org/viewvc?view=revision&revision=1382345
                
> AsyncSchemeRegistry should be settable per-client instance
> ----------------------------------------------------------
>
>                 Key: HTTPASYNC-25
>                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-25
>             Project: HttpComponents HttpAsyncClient
>          Issue Type: Improvement
>    Affects Versions: 4.0-beta2
>            Reporter: Daniel Kulp
>             Fix For: 4.0-beta3
>
>         Attachments: HTTPASYNC-25.patch
>
>
> For CXF, we need to be able to pass a specific SSLLayeringStrategy into the client on a per-client basis, not part of the ConnectionManager.   However, right now, the ManagedClientAsyncConnectionImpl class always uses the AsyncSchemeRegistry of the manager without consulting the registry already stored on the HttpContext.  With a couple of minor updates (patch supplied) we can get the CXF tests passing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org