You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/17 14:29:46 UTC
[GitHub] [airflow] randr97 opened a new pull request #8429: [AIRFLOW-5156]
Added auth type to HttpHook
randr97 opened a new pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook
URL: https://github.com/apache/airflow/pull/8429
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] eladkal commented on a change in pull request #8429:
[AIRFLOW-5156] Added auth type to HttpHook
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook
URL: https://github.com/apache/airflow/pull/8429#discussion_r410677930
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -27,20 +28,28 @@ class HttpHook(BaseHook):
"""
Interact with HTTP servers.
+ :param method: the API method to be called
+ :type method: str
:param http_conn_id: connection that has the base API url i.e https://www.google.com/
and optional authentication credentials. Default headers can also be specified in
the Extra field in json format.
:type http_conn_id: str
- :param method: the API method to be called
- :type method: str
+ :param auth_type: the API method to be called
+ :type method: AuthBase of python requests lib
Review comment:
It should be
` :type auth_type: AuthBase of python requests lib`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8429: [AIRFLOW-5156] Added
auth type to HttpHook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook
URL: https://github.com/apache/airflow/pull/8429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services