You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/19 17:46:03 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11575: [BEAM-9699] Add test verifying we can use ZetaSQL in Python SqlTransform

robertwb commented on a change in pull request #11575:
URL: https://github.com/apache/beam/pull/11575#discussion_r427485815



##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -31,8 +31,15 @@
 
 __all__ = ['SqlTransform']
 
+_SQL_PLANNERS = {
+    'zetasql': 'org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner',

Review comment:
       I wonder if it would make more sense for this mapping to live on the Java side, and to have this parameter by called "dialect" or similar. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org