You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/04/11 12:57:23 UTC
[PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
zclllyybb opened a new pull request, #3536:
URL: https://github.com/apache/doris-website/pull/3536
- Change `dynamic_partition.enable` from `"false"` to `"true"` in auto partition example
- Apply to both EN and ZH versions of 3.x docs
## Versions
- [ ] dev
- [ ] 4.x
- [x] 3.x
- [ ] 2.1
## Languages
- [x] Chinese
- [x] English
## Docs Checklist
- [ ] Checked by AI
- [ ] Test Cases Built
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #3536:
URL: https://github.com/apache/doris-website/pull/3536#issuecomment-4229459931
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3536:
URL: https://github.com/apache/doris-website/pull/3536#discussion_r3068025421
##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-3.x/table-design/data-partitioning/auto-partitioning.md:
##########
@@ -243,7 +243,7 @@ auto partition by range (date_trunc(k0, 'year'))
)
DISTRIBUTED BY HASH(`k0`) BUCKETS 2
properties(
- "dynamic_partition.enable" = "false",
+ "dynamic_partition.enable" = "true",
"dynamic_partition.prefix" = "p",
"dynamic_partition.start" = "-50",
"dynamic_partition.end" = "0", --- Dynamic Partition 不创建分区
Review Comment:
这一段文字说明是“关闭 Dynamic Partition 的创建功能”，但示例里现在设置了 `dynamic_partition.enable = "true"` 且 `dynamic_partition.end = "0"`。在 3.x 的动态分区参数说明中，`dynamic_partition.end` 被描述为正数；如果 `0` 不被支持，那么启用后这段建表 SQL 可能不可执行。建议：要么把示例改成受支持的 `end` 值并同步修正文案/注释，要么在文档中明确说明 `end = 0` 是一个特殊用法（例如仅不预创建分区）并澄清它与完全禁用 Dynamic Partition 的区别。
##########
versioned_docs/version-3.x/table-design/data-partitioning/auto-partitioning.md:
##########
@@ -246,7 +246,7 @@ auto partition by range (date_trunc(k0, 'year'))
)
DISTRIBUTED BY HASH(`k0`) BUCKETS 2
properties(
- "dynamic_partition.enable" = "false",
+ "dynamic_partition.enable" = "true",
"dynamic_partition.prefix" = "p",
"dynamic_partition.start" = "-50",
"dynamic_partition.end" = "0", --- Dynamic Partition No Partition Creation
Review Comment:
The surrounding text says to "disable the creation of Dynamic Partition" while keeping it for lifecycle management, but this example now sets `dynamic_partition.enable = "true"` and uses `dynamic_partition.end = "0"`. In the Dynamic Partition docs for 3.x, `dynamic_partition.end` is described as a positive number; if `0` is not supported, this SQL will be invalid once enabled. Please either (1) adjust the example to a supported `end` value and update the explanation/comment accordingly, or (2) explicitly document that `end = 0` is a special case meaning “don’t pre-create partitions” (and clarify how that differs from disabling Dynamic Partition entirely).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3536:
URL: https://github.com/apache/doris-website/pull/3536#issuecomment-4229467871
## Code Review Summary
**Goal of the change:** Fix an incorrect value ( → ) in the Auto Partition "Best Practice" example in the 3.x docs (both EN and ZH locales).
**Critical checkpoint conclusions:**
- **Goal vs. implementation:** The fix correctly addresses the bug. The Best Practice section describes a pattern where Dynamic Partition is *enabled* but configured with so it does not create future partitions — partition creation is delegated to Auto Partition, while Dynamic Partition handles lifecycle/reclamation. Setting would disable Dynamic Partition entirely, defeating the purpose of the pattern. The change to is correct.
- **Scope and focus:** The change is minimal and precisely targeted — 1-line fix, applied symmetrically to both EN () and ZH () files. No unrelated content is modified.
- **Information architecture / version consistency:** After this fix, the 3.x code example is consistent with:
- The 2.1 EN version (), which already uses .
- The 3.x file, which uses the same + pattern with the note *"Dynamic Partition does not create future partitions"*.
- The PR correctly leaves , unchanged (the Conjunct with Dynamic Partition section has been restructured in those versions and does not contain this example).
- **Path / slug / sidebar changes:** None. No navigation references, redirects, or sidebar entries are affected.
- **Docusaurus config / React / build scripts:** Not touched.
- **Validation:** The fix is verifiable by cross-referencing the 2.1 version and , both of which use the same pattern. No build-breaking changes are possible from this content-only fix.
- **Other issues:** No factual errors, broken links, front matter issues, or accessibility problems introduced. One pre-existing minor issue exists (the English 3.x file has a about "early versions prior to 2.1.7" that is absent from the Chinese 3.x file), but this is outside the scope of this PR.
**Verdict:** The fix is correct and consistent. No issues found with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3536:
URL: https://github.com/apache/doris-website/pull/3536#issuecomment-4229468865
## Code Review Summary
**Goal of the change:** Fix an incorrect `dynamic_partition.enable` value (`"false"` → `"true"`) in the Auto Partition "Best Practice" example in the 3.x docs (both EN and ZH locales).
**Critical checkpoint conclusions:**
- **Goal vs. implementation:** The fix correctly addresses the bug. The Best Practice section describes a pattern where Dynamic Partition is *enabled* but configured with `end = "0"` so it does not create future partitions — partition creation is delegated to Auto Partition, while Dynamic Partition handles lifecycle/reclamation. Setting `enable = "false"` would disable Dynamic Partition entirely, defeating the purpose of the pattern. The change to `"true"` is correct.
- **Scope and focus:** The change is minimal and precisely targeted — 1-line fix applied symmetrically to both EN (`versioned_docs/version-3.x/`) and ZH (`i18n/zh-CN/docusaurus-plugin-content-docs/version-3.x/`) files. No unrelated content is modified.
- **Information architecture / version consistency:** After this fix, the 3.x code example is consistent with:
- The 2.1 EN version (`versioned_docs/version-2.1/.../auto-partitioning.md` line 249), which already uses `"true"`.
- The 3.x `basic-concepts.mdx` file, which uses the same `enable = "true"` + `end = "0"` pattern with the note *"Dynamic Partition does not create future partitions"*.
- The PR correctly leaves `dev` and `4.x` unchanged (the Conjunct with Dynamic Partition section has been restructured in those versions and does not contain this example).
- **Path / slug / sidebar changes:** None. No navigation references, redirects, or sidebar entries are affected.
- **Docusaurus config / React / build scripts:** Not touched.
- **Validation:** The fix is verifiable by cross-referencing the 2.1 version and `basic-concepts.mdx`, both of which use the same pattern. No build-breaking changes are possible from this content-only fix.
- **Other issues:** No factual errors, broken links, front matter issues, or accessibility problems introduced. One pre-existing minor asymmetry exists (the English 3.x file has a `:::note` about "early versions prior to 2.1.7" that is absent from the Chinese 3.x file), but this is outside the scope of this PR.
**Verdict:** The fix is correct and consistent. No issues found with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [docs](auto-partition) fix dynamic_partition.enable value in 3.x example [doris-website]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #3536:
URL: https://github.com/apache/doris-website/pull/3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org