You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Himanshu Gahlaut <ga...@gmail.com> on 2015/05/14 13:32:51 UTC

Review Request 34210: LENS-514: Adding unique identifier to log lines

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description
-------

LENS-514: Adding unique identifier to log lines for log segregation


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 9d8748c0734b9c3f99dd9c7daabd27eb88be4973 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

Testing done by executing query from lens-cli and verifying lens-server logs.

Running test suite. Will update test results.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 41
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line41>
> >
> >     It's not really a filter, going by the definition of `filter`. It's merely an `interceptor`. Let's rename it to something like `request enricher` or `request id appender` etc.
> 
> Himanshu Gahlaut wrote:
>     Jersey has a notion in which request and response can be worked upon using container request and response filters. The interfaces are named ContainerRequestFilter and ContainerResponseFilter. Hence keeping the name as filter to align with existing intuition. Initial keyword is used with purpose as this is the first filter to be called among all filters when a request is processed by container.
> 
> Rajat Khandelwal wrote:
>     For a person trying to understand the code for the first time, the name `Initial Request Filter` is not very descriptive. It sounds like it's filtering an initial request. I just think that regardless of jersey naming conventions, we should keep our code as readable as possible.

Renaming it to LensRequestContextInitFilter


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84119
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java, line 21
> > <https://reviews.apache.org/r/34210/diff/2/?file=959324#file959324line21>
> >
> >     Rename this to something other than the all-generic `Constant`. It doesn't yet contain every possible `Constant` to be eligible for the name `Constant`.
> 
> Himanshu Gahlaut wrote:
>     Couldn't figure out anything common between REQUEST_ID and LOG_SEGREGATION_ID to assign a common name to them. Please feel free to suggest a name which can relate these two constants. Putting both of them in separate enums will be enum bloat. Hence started a generic common Constant enum in lens-server-api which doesn't exist right now.
> 
> Rajat Khandelwal wrote:
>     so REQUEST_ID is used in only one place, it can move there. `LOG_SEGGREGATION_ID` is only used like the following:
>     
>         MDC.put(Constant.LOG_SEGREGATION_ID.getValue(), something)
>     
>     or
>         MDC.get(Constant.LOG_SEGREGATION_ID.getValue());
>     
>     
>     These methods can be abstracted out in a new or old class(say, `LogHelper`) which can internally store the constant.

will move REQUEST_ID to LensRequestContextInitFilter. Helper classes tends to become code smell in longer run. Will encapsulate log segregation into a domain problem and provide domain objects for the same.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84119
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java, line 21
> > <https://reviews.apache.org/r/34210/diff/2/?file=959324#file959324line21>
> >
> >     Rename this to something other than the all-generic `Constant`. It doesn't yet contain every possible `Constant` to be eligible for the name `Constant`.

Couldn't figure out anything common between REQUEST_ID and LOG_SEGREGATION_ID to assign a common name to them. Please feel free to suggest a name which can relate these two constants. Putting both of them in separate enums will be enum bloat. Hence started a generic common Constant enum in lens-server-api which doesn't exist right now.


> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 41
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line41>
> >
> >     It's not really a filter, going by the definition of `filter`. It's merely an `interceptor`. Let's rename it to something like `request enricher` or `request id appender` etc.

Jersey has a notion in which request and response can be worked upon using container request and response filters. The interfaces are named ContainerRequestFilter and ContainerResponseFilter. Hence keeping the name as filter to align with existing intuition. Initial keyword is used with purpose as this is the first filter to be called among all filters when a request is processed by container.


> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensApplication.java, line 78
> > <https://reviews.apache.org/r/34210/diff/2/?file=959329#file959329line78>
> >
> >     We can probably make it configurable, whether to add this filter or not.

Not required. Things can be made configurable based on their need. Making everything configurable creates a maintainence overhead in configuration files.


> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 849
> > <https://reviews.apache.org/r/34210/diff/2/?file=959332#file959332line849>
> >
> >     What happens when multiple threads(e.g. one submitter thread, one purger thread) both try to do `MDC.put`?

Both thread works on their own MDC context. So both of them modifies their own MDC context.


> On May 18, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/resources/log4j.properties, line 34
> > <https://reviews.apache.org/r/34210/diff/2/?file=959335#file959335line34>
> >
> >     shouldn't we also add request id?

Query handle, request id and run id are acting as log segregation id in different contexts. Query handle is preferred over request id which is preferred of run id.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84119
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On May 18, 2015, 1:38 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java, line 21
> > <https://reviews.apache.org/r/34210/diff/2/?file=959324#file959324line21>
> >
> >     Rename this to something other than the all-generic `Constant`. It doesn't yet contain every possible `Constant` to be eligible for the name `Constant`.
> 
> Himanshu Gahlaut wrote:
>     Couldn't figure out anything common between REQUEST_ID and LOG_SEGREGATION_ID to assign a common name to them. Please feel free to suggest a name which can relate these two constants. Putting both of them in separate enums will be enum bloat. Hence started a generic common Constant enum in lens-server-api which doesn't exist right now.

so REQUEST_ID is used in only one place, it can move there. `LOG_SEGGREGATION_ID` is only used like the following:

    MDC.put(Constant.LOG_SEGREGATION_ID.getValue(), something)

or
    MDC.get(Constant.LOG_SEGREGATION_ID.getValue());


These methods can be abstracted out in a new or old class(say, `LogHelper`) which can internally store the constant.


> On May 18, 2015, 1:38 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 41
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line41>
> >
> >     It's not really a filter, going by the definition of `filter`. It's merely an `interceptor`. Let's rename it to something like `request enricher` or `request id appender` etc.
> 
> Himanshu Gahlaut wrote:
>     Jersey has a notion in which request and response can be worked upon using container request and response filters. The interfaces are named ContainerRequestFilter and ContainerResponseFilter. Hence keeping the name as filter to align with existing intuition. Initial keyword is used with purpose as this is the first filter to be called among all filters when a request is processed by container.

For a person trying to understand the code for the first time, the name `Initial Request Filter` is not very descriptive. It sounds like it's filtering an initial request. I just think that regardless of jersey naming conventions, we should keep our code as readable as possible.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84119
-----------------------------------------------------------


On May 14, 2015, 7:36 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 7:36 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84119
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java
<https://reviews.apache.org/r/34210/#comment135235>

    Rename this to something other than the all-generic `Constant`. It doesn't yet contain every possible `Constant` to be eligible for the name `Constant`.



lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java
<https://reviews.apache.org/r/34210/#comment135237>

    It's not really a filter, going by the definition of `filter`. It's merely an `interceptor`. Let's rename it to something like `request enricher` or `request id appender` etc.



lens-server/src/main/java/org/apache/lens/server/LensApplication.java
<https://reviews.apache.org/r/34210/#comment135236>

    We can probably make it configurable, whether to add this filter or not.



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/34210/#comment135238>

    What happens when multiple threads(e.g. one submitter thread, one purger thread) both try to do `MDC.put`?



lens-server/src/test/resources/log4j.properties
<https://reviews.apache.org/r/34210/#comment135239>

    shouldn't we also add request id?


- Rajat Khandelwal


On May 14, 2015, 7:36 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 7:36 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 28, 2015, 6:57 a.m.)


Review request for lens.


Changes
-------

Rebasing with current master.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description (updated)
-------

LENS-514: Adding unique identifier to log lines


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 4f03f230f7a5d02e2263af88ebd25953b34a4ae9 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 7c2da3a91738917c750da574d85123939e06f211 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 34e14b619e1da81fbc2ed912102bf6ef8711e448 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java d5e60c41fca88f32786f9ee21b37e8e6807c7827 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

Update [May 26, 2015]: All failing tests cases fixed. Results below. Patch is rebased with current master and ready to commit.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.798s]
[INFO] Lens .............................................. SUCCESS [3.611s]
[INFO] Lens API .......................................... SUCCESS [10.580s]
[INFO] Lens API for server and extensions ................ SUCCESS [11.360s]
[INFO] Lens Cube ......................................... SUCCESS [4:58.177s]
[INFO] Lens DB storage ................................... SUCCESS [23.225s]
[INFO] Lens Query Library ................................ SUCCESS [7.089s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:25.769s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.329s]
[INFO] Lens Server ....................................... SUCCESS [10:48.815s]
[INFO] Lens client ....................................... SUCCESS [40.070s]
[INFO] Lens CLI .......................................... SUCCESS [4:13.215s]
[INFO] Lens Examples ..................................... SUCCESS [1.576s]
[INFO] Lens Distribution ................................. SUCCESS [13.020s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:56.296s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [14.103s]
[INFO] Lens Regression ................................... SUCCESS [1.693s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:57.630s
[INFO] Finished at: Tue May 26 21:01:28 UTC 2015
[INFO] Final Memory: 110M/351M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 26, 2015, 9:09 p.m.)


Review request for lens.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description
-------

Fixed failing test cases.


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4cf1fa9df93ac7257f10d68249496981c02be7df 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing (updated)
-------

Update [May 26, 2015]: All failing tests cases fixed. Results below. Patch is rebased with current master and ready to commit.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.798s]
[INFO] Lens .............................................. SUCCESS [3.611s]
[INFO] Lens API .......................................... SUCCESS [10.580s]
[INFO] Lens API for server and extensions ................ SUCCESS [11.360s]
[INFO] Lens Cube ......................................... SUCCESS [4:58.177s]
[INFO] Lens DB storage ................................... SUCCESS [23.225s]
[INFO] Lens Query Library ................................ SUCCESS [7.089s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:25.769s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.329s]
[INFO] Lens Server ....................................... SUCCESS [10:48.815s]
[INFO] Lens client ....................................... SUCCESS [40.070s]
[INFO] Lens CLI .......................................... SUCCESS [4:13.215s]
[INFO] Lens Examples ..................................... SUCCESS [1.576s]
[INFO] Lens Distribution ................................. SUCCESS [13.020s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:56.296s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [14.103s]
[INFO] Lens Regression ................................... SUCCESS [1.693s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:57.630s
[INFO] Finished at: Tue May 26 21:01:28 UTC 2015
[INFO] Final Memory: 110M/351M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 26, 2015, 9:09 p.m.)


Review request for lens.


Changes
-------

All failing tests cases fixed. Results below. Patch is rebased with current master and ready to commit.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description (updated)
-------

Fixed failing test cases.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4cf1fa9df93ac7257f10d68249496981c02be7df 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing (updated)
-------

One unit test case is failing. Will update review request again after fixing the test case and running test suite again.

Update [May 26, 2015]: All failing tests cases fixed. Results below. Patch is rebased with current master and ready to commit.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.798s]
[INFO] Lens .............................................. SUCCESS [3.611s]
[INFO] Lens API .......................................... SUCCESS [10.580s]
[INFO] Lens API for server and extensions ................ SUCCESS [11.360s]
[INFO] Lens Cube ......................................... SUCCESS [4:58.177s]
[INFO] Lens DB storage ................................... SUCCESS [23.225s]
[INFO] Lens Query Library ................................ SUCCESS [7.089s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:25.769s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.329s]
[INFO] Lens Server ....................................... SUCCESS [10:48.815s]
[INFO] Lens client ....................................... SUCCESS [40.070s]
[INFO] Lens CLI .......................................... SUCCESS [4:13.215s]
[INFO] Lens Examples ..................................... SUCCESS [1.576s]
[INFO] Lens Distribution ................................. SUCCESS [13.020s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:56.296s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [14.103s]
[INFO] Lens Regression ................................... SUCCESS [1.693s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:57.630s
[INFO] Finished at: Tue May 26 21:01:28 UTC 2015
[INFO] Final Memory: 110M/351M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review84862
-----------------------------------------------------------


Changes look fine. Testing done says some tests are failing. Please fix them and update

- Amareshwari Sriramadasu


On May 20, 2015, 2:57 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 2:57 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
>   lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
>   lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> One unit test case is failing. Will update review request again after fixing the test case and running test suite again.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 20, 2015, 2:57 a.m.)


Review request for lens.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description (updated)
-------

LENS-514: Adding unique identifier to log lines for log segregation


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

One unit test case is failing. Will update review request again after fixing the test case and running test suite again.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 20, 2015, 2:56 a.m.)


Review request for lens.


Changes
-------

Minor changes.


Summary (updated)
-----------------

LENS-514: Adding unique identifier to log lines


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description (updated)
-------

Minor changes.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

One unit test case is failing. Will update review request again after fixing the test case and running test suite again.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Addition of an identifier in every log line for segregating logs

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 20, 2015, 2:48 a.m.)


Review request for lens.


Summary (updated)
-----------------

LENS-514: Addition of an identifier in every log line for segregating logs


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description
-------

Addressed code review comments.


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

One unit test case is failing. Will update review request again after fixing the test case and running test suite again.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Addition of an identifier in every line of log for segregating logs

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 20, 2015, 2:48 a.m.)


Review request for lens.


Changes
-------

Addressed review comments.


Summary (updated)
-----------------

LENS-514: Addition of an identifier in every line of log for segregating logs


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description (updated)
-------

Addressed code review comments.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 71fbc7454ad7f20ca674c384723e3e3300cefbc6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 87e4638c51bb03138c41327a4228c8f9e6fbd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 75c428a1f70ed091bdae4597d36b334b09e91c27 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java da44955405267b35306601e1669803c82a109267 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 8b6d13170966123cd5d16eb9d6f476d27c46ee3d 
  lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java f769619365e5f098c2634445cad788a6707ef571 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 1c6f18686b2cc347273ae0940797c9cfd4a5b47b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 131a37533507442f76b1eb2b015f66255e9ea2ac 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 254632b6bcf384482365fce19a7c6cfe6b17b974 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java 78e4518b365bb52873cd6a2767e126a8b1d5083b 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7913845caea9f06f0db026ad06855cc87a7617ba 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java decd6ef191be3fbb53839713583037257f738659 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java bf0526f2d6d71a170a16b767ad7582aa28c9a863 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing (updated)
-------

One unit test case is failing. Will update review request again after fixing the test case and running test suite again.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 52
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line52>
> >
> >     Will this be available for all threads, not just the thread which served the request? I think its not.
> >     
> >     If not, estimate api involves different threads from thread pool.
> 
> Himanshu Gahlaut wrote:
>     It will be available for all http server threads and child threads of http server threads. Will add query handle for estimate threads.
> 
> Amareshwari Sriramadasu wrote:
>     Estimate and explain may not have query handle. Only if query is accepted for execution, query handle is generated. We might have to go with requestid itself for simple estimate/explain api.

QuerySubmitter also makes use of background threads of estimate pool to do estimate operations and it doesn't have hold of request id. Will it be appropriate to use query handle for estimates triggered by QuerySubmitter and request id for estimates triggered by QueryServiceResource ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83890
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 52
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line52>
> >
> >     Will this be available for all threads, not just the thread which served the request? I think its not.
> >     
> >     If not, estimate api involves different threads from thread pool.
> 
> Himanshu Gahlaut wrote:
>     It will be available for all http server threads and child threads of http server threads. Will add query handle for estimate threads.
> 
> Amareshwari Sriramadasu wrote:
>     Estimate and explain may not have query handle. Only if query is accepted for execution, query handle is generated. We might have to go with requestid itself for simple estimate/explain api.
> 
> Himanshu Gahlaut wrote:
>     QuerySubmitter also makes use of background threads of estimate pool to do estimate operations and it doesn't have hold of request id. Will it be appropriate to use query handle for estimates triggered by QuerySubmitter and request id for estimates triggered by QueryServiceResource ?

>> Will it be appropriate to use query handle for estimates triggered by QuerySubmitter and request id for estimates triggered by QueryServiceResource ?

Sounds OK to me. Could not think of anyother option.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83890
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 52
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line52>
> >
> >     Will this be available for all threads, not just the thread which served the request? I think its not.
> >     
> >     If not, estimate api involves different threads from thread pool.
> 
> Himanshu Gahlaut wrote:
>     It will be available for all http server threads and child threads of http server threads. Will add query handle for estimate threads.

Estimate and explain may not have query handle. Only if query is accepted for execution, query handle is generated. We might have to go with requestid itself for simple estimate/explain api.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83890
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java, line 52
> > <https://reviews.apache.org/r/34210/diff/2/?file=959328#file959328line52>
> >
> >     Will this be available for all threads, not just the thread which served the request? I think its not.
> >     
> >     If not, estimate api involves different threads from thread pool.

It will be available for all http server threads and child threads of http server threads. Will add query handle for estimate threads.


> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 489
> > <https://reviews.apache.org/r/34210/diff/2/?file=959332#file959332line489>
> >
> >     Other background threads like
> >     
> >     - JDBCDriver's query execution threads
> >     - ResultFormatter
> >     - QueryEndNotifier
> >     - StatisticsLogger
> >     
> >     Can also be associated with LOG_SEGREGATION_ID.

Added to all these threads as well.


> On May 15, 2015, 3:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServer.java, line 192
> > <https://reviews.apache.org/r/34210/diff/2/?file=959330#file959330line192>
> >
> >     Shall we add the same for CheckPointSnapshotThread as well?

Added


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83890
-----------------------------------------------------------


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83890
-----------------------------------------------------------



lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java
<https://reviews.apache.org/r/34210/#comment134969>

    Will this be available for all threads, not just the thread which served the request? I think its not.
    
    If not, estimate api involves different threads from thread pool.



lens-server/src/main/java/org/apache/lens/server/LensApplication.java
<https://reviews.apache.org/r/34210/#comment134968>

    Is this a debug log?



lens-server/src/main/java/org/apache/lens/server/LensServer.java
<https://reviews.apache.org/r/34210/#comment134971>

    Shall we add the same for CheckPointSnapshotThread as well?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/34210/#comment134970>

    Other background threads like
    
    - JDBCDriver's query execution threads
    - ResultFormatter
    - QueryEndNotifier
    - StatisticsLogger
    
    Can also be associated with LOG_SEGREGATION_ID.


- Amareshwari Sriramadasu


On May 14, 2015, 2:06 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/
-----------------------------------------------------------

(Updated May 14, 2015, 2:06 p.m.)


Review request for lens.


Changes
-------

(1) Added a unique id to relate startup and shutdown logs.
(2) Fixed unit test case failures.


Bugs: LENS-514
    https://issues.apache.org/jira/browse/LENS-514


Repository: lens


Description
-------

LENS-514: Adding unique identifier to log lines for log segregation


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
  lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
  lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
  lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 0d23726a895a11208249b7ce458cb34e2265feeb 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
  lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
  tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
  tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 

Diff: https://reviews.apache.org/r/34210/diff/


Testing
-------

Testing done by executing query from lens-cli and verifying lens-server logs.

Running test suite. Will update test results.


Thanks,

Himanshu Gahlaut


Re: Review Request 34210: LENS-514: Adding unique identifier to log lines

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34210/#review83750
-----------------------------------------------------------

Ship it!


Nice!

- Amareshwari Sriramadasu


On May 14, 2015, 11:32 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34210/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 11:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-514
>     https://issues.apache.org/jira/browse/LENS-514
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-514: Adding unique identifier to log lines for log segregation
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 7b615e6216d7a31a743416dd839a63517be88e1f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java efa04f1c7e7fddbd9176922425c66057f4be3089 
>   lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java f6c3593a131ab6779186be014d79b9f4c4cb9534 
>   lens-server-api/src/main/java/org/apache/lens/server/api/common/Constant.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 9d8748c0734b9c3f99dd9c7daabd27eb88be4973 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 1ce89ac66fa817b3e47482a81b040259d2194477 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 169ac8dec4b98a0cab1f652fe85afe9737f02e39 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java b64d8223727d755aad95dee288f9561b767a5448 
>   lens-server/src/main/java/org/apache/lens/server/InitialRequestFilter.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java c6d7ea154f4c3f78eaa0675d99364a311351bf4c 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9b6d6bc223069b28367d789db847cbf05ed386c7 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5e135be0348068125b69016274e00b01140c4f21 
>   lens-server/src/test/resources/log4j.properties 65d065fa699f9797dcb13580359c4d41cfc52e9d 
>   tools/conf-pseudo-distr/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
>   tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 
> 
> Diff: https://reviews.apache.org/r/34210/diff/
> 
> 
> Testing
> -------
> 
> Testing done by executing query from lens-cli and verifying lens-server logs.
> 
> Running test suite. Will update test results.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>