[GitHub] [cordova-plugin-media-capture] ath0mas edited a comment on pull request #162: (iOS) implement the 'quality' property in captureVideo()

[GitBox <gi...@apache.org>]

ath0mas edited a comment on pull request #162:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/162#issuecomment-797117757


   Previously, no `videoQuality` was set for _pickerController_ and so it resolved to _medium_ (see [doc](https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619154-videoquality?language=objc)).
   Following this plugin default value of `1` for _quality_ is fine but seems to be a **breaking change** for iOS.
   
   Based on the decisions from #48 and #65, with work of @maxpaj, @jcesarmobile and others we still go for the values `0`, `0.5` and `1`.
   
   ---
   I suggest:
   1. to remove `quality` from [CaptureVideoOptions.js](https://github.com/apache/cordova-plugin-media-capture/blob/master/www/CaptureVideoOptions.js): this object is only used for _windows_ and in tests, and never expecting `quality`
   1. to make this plugin follow each platform default _quality_ for its own default config/fallback code
       1. update README with distinct Android and iOS Quirks about `quality` param as it is not available for other platforms, and making it clear that the default value is different between Android and iOS following each native platform defaults
       1. value of `1`/_High_ is Android default
           Seems OK right now: we [init](https://github.com/apache/cordova-plugin-media-capture/blob/master/src/android/PendingRequests.java#L179) and [optInt](https://github.com/apache/cordova-plugin-media-capture/blob/master/src/android/PendingRequests.java#L194) with `1`, and then the fallback behavior is resolved by Android itself since we directly pass whatever value the user defined (see [ref](https://github.com/apache/cordova-plugin-media-capture/blob/master/src/android/Capture.java#L307)).
       1. value of `0.5`/_Medium_ is iOS default
           Requires changes on this PR: like
           ```
           case 0:
               Low;
           case 10:
               High;
           case 5:
           default:
               Medium;
           ```
           for explicit `0.5` and fallback to both resolve to _Medium_


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org