You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/08 03:41:30 UTC
[GitHub] [shardingsphere] doveylovey opened a new pull request, #22002: fix some bugs in the transaction module
doveylovey opened a new pull request, #22002:
URL: https://github.com/apache/shardingsphere/pull/22002
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] doveylovey commented on pull request #22002: fix some bugs in the transaction module
Posted by GitBox <gi...@apache.org>.
doveylovey commented on PR #22002:
URL: https://github.com/apache/shardingsphere/pull/22002#issuecomment-1308202742
> Please explain the reason if this is a bug.
What's the point of unit testing if you don't perform some business operation?
It's probably not a bug, it's an optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22002: fix some bugs in the transaction module
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22002:
URL: https://github.com/apache/shardingsphere/pull/22002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22002: fix some bugs in the transaction module
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22002:
URL: https://github.com/apache/shardingsphere/pull/22002#issuecomment-1306607782
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22002](https://codecov.io/gh/apache/shardingsphere/pull/22002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e9ad01) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5b235c0513465528c8e17dfc6a8dd59c6f4249bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b235c0) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22002 +/- ##
============================================
- Coverage 60.88% 60.87% -0.01%
Complexity 2467 2467
============================================
Files 4109 4109
Lines 57242 57242
Branches 9688 9688
============================================
- Hits 34850 34847 -3
- Misses 19450 19453 +3
Partials 2942 2942
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org