You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/20 03:30:33 UTC
[GitHub] [arrow-datafusion] doki23 opened a new issue #2041: Wildcard should not be allowed in LogicalPlan
doki23 opened a new issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041
Actually, it's not a functionality bug. It's my confusion about the unit test: **logical_plan::builder::tests::plan_using_join_wildcard_projection**
The following is some code in the test.
```
let plan = LogicalPlanBuilder::scan_empty(Some("t1"), &employee_schema(), None)?
.join_using(&t2, JoinType::Inner, vec!["id"])?
.project(vec![Expr::Wildcard])? // my question about here
.build()?;
```
I find some error descriptions in other places like:
```
Expr::Wildcard { .. } => Err(DataFusionError::Internal(
"Wildcard expressions are not valid in a logical query plan".to_owned(),
))
```
And in the sql planner, we always expand the wildcard before generating a logical plan.
So the unit test may be wrong, please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 commented on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 commented on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1075800578
As discussed in #2012 , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1075800578
As discussion https://github.com/apache/arrow-datafusion/pull/2012#issuecomment-1075194168 , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
Of course, when we finish building the LogicalPlan, there's no wildcard expression in the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 closed issue #2041: Do some pre-check when building LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 closed issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1073158864
It's related to another pr: #2012
@houqp @xudong963 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1073219075
FWIW I would expect this code:
```rust
let plan = LogicalPlanBuilder::scan_empty(Some("t1"), &employee_schema(), None)?
.join_using(&t2, JoinType::Inner, vec!["id"])?
.project(vec![Expr::Wildcard])? // my question about here
.build()?;
```
To generate a DataFusionError with "Wildcard expressions are not valid in a logical query plan"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1075800578
As discussion https://github.com/apache/arrow-datafusion/pull/2012#issuecomment-1075194168 , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
Of course, when we have built the LogicalPlan, there's no wildcard expression in the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 commented on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 commented on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1073158864
It's related to another pr: #2012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1075800578
As discussed https://github.com/apache/arrow-datafusion/pull/2012#issuecomment-1075194168 , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1073158864
@houqp @xudong963 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] doki23 edited a comment on issue #2041: Wildcard should not be allowed in LogicalPlan
Posted by GitBox <gi...@apache.org>.
doki23 edited a comment on issue #2041:
URL: https://github.com/apache/arrow-datafusion/issues/2041#issuecomment-1075800578
As discussion https://github.com/apache/arrow-datafusion/pull/2012#issuecomment-1075194168 , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org