You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James Clarke (JIRA)" <ji...@apache.org> on 2009/09/16 16:20:58 UTC
[jira] Created: (THRIFT-584) php compiler does not create package
directory structure
php compiler does not create package directory structure
--------------------------------------------------------
Key: THRIFT-584
URL: https://issues.apache.org/jira/browse/THRIFT-584
Project: Thrift
Issue Type: Bug
Components: Compiler (PHP)
Reporter: James Clarke
Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756132#action_12756132 ]
David Reiss commented on THRIFT-584:
------------------------------------
My bad. I thought it was pretty open-and-shut, but that might just be my Facebook bias since we don't have an automated system for generating our php code. I am very much open to discussion.
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-584) php compiler does not create package
directory structure
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-584.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.2
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "James Clarke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756192#action_12756192 ]
James Clarke commented on THRIFT-584:
-------------------------------------
FYI, I actually thought this was bug rather than an improvement since the the README in lib/php explicitly mentions that:
{quote}
When you generate a Thrift package using the compiler, it makes an assumption
about where your generated code will live. If your file is "MyPackage.thrift",
the generated files must be installed into:
$GLOBALS['THRIFT_ROOT'].'/packages/MyPackage/';
This allows the code generator to compile your code without any extra flags
for the target directory names while still allowing your include paths to
be absolute (if you have an absolute THRIFT_ROOT).
{quote}
It seemed strange that the compiler wouldn't give the structure automatically, as then I could just copy {{gen-php/*}} to {{$GLOBALS['THRIFT_ROOT'].'/packages}}
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch, v1-0001-THRIFT-584.-Note-that-r815878-might-break-build-scri.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756125#action_12756125 ]
Todd Lipcon commented on THRIFT-584:
------------------------------------
Looks like this got committed? It doesn't seem like there was any time for review, and this is a breaking change. There also was no update to CHANGES, which I assume should be done in the case of incompatible changes.
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756139#action_12756139 ]
David Reiss commented on THRIFT-584:
------------------------------------
Yes, there is a branch for 0.1: http://svn.apache.org/repos/asf/incubator/thrift/branches/0.1.x/ I'll attach a patch for CHANGES momentarily.
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-584) php compiler does not create package
directory structure
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-584:
-------------------------------
Attachment: v1-0001-THRIFT-584.-Note-that-r815878-might-break-build-scri.patch
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch, v1-0001-THRIFT-584.-Note-that-r815878-might-break-build-scri.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-584) php compiler does not create package
directory structure
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-584:
-------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-584) php compiler does not create package
directory structure
Posted by "James Clarke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Clarke updated THRIFT-584:
--------------------------------
Attachment: thrift-584-php-generate-package-directory-structure.patch
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (PHP)
> Reporter: James Clarke
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (THRIFT-584) php compiler does not create package
directory structure
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reopened THRIFT-584:
--------------------------------
Reopening since I think this should get at least a little discussion
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-584) php compiler does not create package
directory structure
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved THRIFT-584.
--------------------------------
Resolution: Fixed
This is going out in 0.2.
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch, v1-0001-THRIFT-584.-Note-that-r815878-might-break-build-scri.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756134#action_12756134 ]
Todd Lipcon commented on THRIFT-584:
------------------------------------
I think it's a good improvement, I just want to make sure it gets noted on some list of breaking changes, and make sure it doesn't go into 0.1 (is there a branch for the 0.1 rc series? I don't see one but I might be missing something)
(I know I've set up "build script"s for thrift code that generate it and then move it into place in a directory tree, and those will need slight updates with this change)
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-584) php compiler does not create package
directory structure
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756144#action_12756144 ]
Todd Lipcon commented on THRIFT-584:
------------------------------------
+1, looks good to me.
Another thing to consider is to get a "Release Note" field added to JIRA. Hadoop uses this on every commit, and then when a release is done it's pretty easy to generate release notes by doing a fancy JIRA search. I'm not sure if we can do that ourselves or if we have to file an INFRA ticket
> php compiler does not create package directory structure
> --------------------------------------------------------
>
> Key: THRIFT-584
> URL: https://issues.apache.org/jira/browse/THRIFT-584
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (PHP)
> Reporter: James Clarke
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-584-php-generate-package-directory-structure.patch, v1-0001-THRIFT-584.-Note-that-r815878-might-break-build-scri.patch
>
>
> Generated php files refer to included thrift packages as {{$GLOBALS['THRIFT_ROOT'].'/packages/<package name>/'}}. The thrift compiler generates all php files into {{gen-php}} instead of {{gen-php/<package name>}}. Attached patch fixes the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.