You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2012/03/12 09:59:37 UTC
[jira] [Created] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Move CfDef and KsDef validation to CFMetaData and KSMetaData
------------------------------------------------------------
Key: CASSANDRA-4037
URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
Project: Cassandra
Issue Type: Improvement
Reporter: Sylvain Lebresne
Priority: Minor
Fix For: 1.1.1
Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235663#comment-13235663 ]
Jonathan Ellis commented on CASSANDRA-4037:
-------------------------------------------
+1, tho i'd be ok w/ leaving the debug line in
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
> Attachments: 0001-Fix-CFMetadata-copyOpts.txt
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4037:
----------------------------------------
Fix Version/s: (was: 1.1.1)
1.1.0
I've cherry-picked this patch to 1.1.0 too for CASSANDRA-4093 sakes.
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: 0001-Fix-CFMetadata-copyOpts.txt
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reopened CASSANDRA-4037:
-----------------------------------------
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235050#comment-13235050 ]
Jonathan Ellis commented on CASSANDRA-4037:
-------------------------------------------
+1
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234207#comment-13234207 ]
Sylvain Lebresne commented on CASSANDRA-4037:
---------------------------------------------
Pushed patch to https://github.com/pcmanus/cassandra/commits/4037
This move validation to CFMetaData and KSMetaData and the remove any now useless conversion to/from thrift. The patch is against cassandra-1.1 and to be honest it moves quite a bit of code around so even though that's a direct follow up of CASSANDRA-3792, there is probably no point pushing this to 1.1.0.
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4037:
----------------------------------------
Attachment: 0001-Fix-CFMetadata-copyOpts.txt
This patch actually broke the distributed tests because CFMetaData.copyOpts wasn't correctly cloning the columns metadata. Attached fix (against 1.1.1, copyOpts is not used in previous version).
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
> Attachments: 0001-Fix-CFMetadata-copyOpts.txt
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reassigned CASSANDRA-4037:
-------------------------------------------
Assignee: Sylvain Lebresne
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4037) Move CfDef and KsDef validation
to CFMetaData and KSMetaData
Posted by "Sylvain Lebresne (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-4037.
-----------------------------------------
Resolution: Fixed
Reviewer: jbellis
Committed, thanks
> Move CfDef and KsDef validation to CFMetaData and KSMetaData
> ------------------------------------------------------------
>
> Key: CASSANDRA-4037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4037
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.1
>
>
> Following CASSANDRA-3792, CQL don't need to use thrift CfDef and KsDef. However, those are still used in order to reuse ThriftValidation validation methods. We should move that validation to CFM and KSM and remove the use of those thrift structures by CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira