You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/26 02:43:01 UTC
[GitHub] [netbeans] pepness opened a new pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
pepness opened a new pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272
This is an improvement to the [PR-2023](https://github.com/apache/netbeans/pull/2023) from Josh Juneau. I used the `j2ee.platform` as a reference.
Notes:
- Add module 'jakartaee.platform' that contains the Javadoc
- Fix JakartaEE integration with the NetBeans library (Classpath & Javadoc)
from both jakartaee-api & jakartaee-web-api libraries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-671025235
Thank you for integrating and checking. For the version: Yes I think the name should contain the major version (that was what I meant with revision number in the name). If that is done, the doc artifact should also get the version number:
So `docs/jakartaee-doc-api.jar` should become `docs/jakartaee8-doc-api.jar` (feel free to reorder, the placement is just a suggestion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-669141864
Thanks @juneau001 @pepness
Assuming retriggered tests are green, I'll merge into master for 12.1 beta2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE 8 Platform module
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-671552997
Commits squashed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a change in pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
pepness commented on a change in pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#discussion_r467514390
##########
File path: enterprise/jakartaee.platform/build.xml
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project basedir="." default="build" name="enterprise/jakartaee.platform">
+
+ <import file="../../nbbuild/templates/projectized.xml"/>
+ <property file="nbproject/project.properties" />
+
+ <!-- Hook into harness "-process.release.files" task -->
+ <target name="-process.release.files" depends="prepare-doc"/>
+
+ <!-- Check if generated doc file was already generated -->
+ <target name="-check-prepared-doc">
+ <condition property="jakartaee.platform.doccreated" value="present">
+ <and>
+ <available file="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar" />
+ </and>
+ </condition>
+ </target>
+
+ <target name="prepare-doc" depends="-check-prepared-doc" unless="jakartaee.platform.doccreated">
+ <delete file="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar" />
+
+ <!-- repackage doc file into the format netbeans used prior to switching to the maven central artefact -->
+ <jar destfile="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar">
+ <zipfileset src="external/jakarta.jakartaee-api-8.0.0-javadoc.jar" includes="**" prefix="docs/api" />
+ </jar>
Review comment:
Did not notice that license file, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-664978616
Possible for 12.1?
@juneau001 please take a look. Can't seem to add you as a reviewer?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-671235163
Assuming review complete, this needs squashing and force pushing here. @matthiasblaesing you happy with requested changes? If not, have to decide whether to push back to 12.2.
On squashing, better if you can do it @pepness but if the branch permissions are open (as default) I can do that before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #2272: [NETBEANS-4635] - Add JakartaEE 8 Platform module
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-670992781
@matthiasblaesing I just review your PR it did the work done. I re-build and re-test this PR and also check that the binaries where in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#discussion_r467464201
##########
File path: enterprise/jakartaee.platform/build.xml
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project basedir="." default="build" name="enterprise/jakartaee.platform">
+
+ <import file="../../nbbuild/templates/projectized.xml"/>
+ <property file="nbproject/project.properties" />
+
+ <!-- Hook into harness "-process.release.files" task -->
+ <target name="-process.release.files" depends="prepare-doc"/>
+
+ <!-- Check if generated doc file was already generated -->
+ <target name="-check-prepared-doc">
+ <condition property="jakartaee.platform.doccreated" value="present">
+ <and>
+ <available file="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar" />
+ </and>
+ </condition>
+ </target>
+
+ <target name="prepare-doc" depends="-check-prepared-doc" unless="jakartaee.platform.doccreated">
+ <delete file="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar" />
+
+ <!-- repackage doc file into the format netbeans used prior to switching to the maven central artefact -->
+ <jar destfile="external/generated-jakarta.jakartaee-api-8.0.0-javadoc.jar">
+ <zipfileset src="external/jakarta.jakartaee-api-8.0.0-javadoc.jar" includes="**" prefix="docs/api" />
+ </jar>
Review comment:
Please also add a license file for the generated package. See the `j2ee.platform/external` situation as reference. The generated package has the same license as its source, but we need the license information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-670968016
@pepness This is commit should do it: https://github.com/matthiasblaesing/netbeans/commit/a0cf9ea8300c761a4858ecae24651d4b94ba7299 - feel free to review and pull into this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-670993729
> I don't know the history, so the question might be invalid: should the jakartaee.platform module contain a revision number? I would expect Jakarta 9 to change and they might (or even have?) decide to change packages, so will this impact us?
>
You are right about this, JakartaEE 9 change the packages names from javax to jakarta:
- [Jakarta EE 9 API Docs](https://jakarta.ee/specifications/platform/9/apidocs/)
- [Jakarta EE 8 API Docs](https://jakarta.ee/specifications/platform/8/apidocs/)
This is the [Backwards Compatibility](https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan) statement for Jakarta EE 9
>
> Backwards Compatibility
>
> Jakarta EE 9 WILL NOT impose any backward compatibility requirements for compatible implementations to support the Jakarta EE 8 release. This is aligned with our goal of enabling new implementations to enter the ecosystem. However, we strongly believe that many products and tools will provide backwards compatibility and migration solutions for enabling older applications to run on Jakarta EE 9.
So I think the new module 'jakartaee.platform' should be renamed to 'jakartaee8.platform' and remove the revision number?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] juneau001 commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
juneau001 commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-665298129
Hi Neil, I can take a look but timing at not work out. I am away with my family and will have limited connectivity this week. I will try to take a look at this, but probably cannot push any changes until early next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE 8 Platform module
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-671901533
Thanks for handling the squash @pepness - merging now and I'll sync for beta 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2272: [NETBEANS-4635] - Add JakartaEE Platform module
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2272:
URL: https://github.com/apache/netbeans/pull/2272#issuecomment-671153769
Modification done. Update images and the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists