You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/17 09:30:15 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #818: WIP - MINIFICPP-1263 - Possible fix for segfault

adamdebreceni commented on a change in pull request #818:
URL: https://github.com/apache/nifi-minifi-cpp/pull/818#discussion_r441411809



##########
File path: extensions/http-curl/tests/AbsoluteTimeoutTest.cpp
##########
@@ -47,4 +47,6 @@ int main() {
   plan->runNextProcessor();
 
   assert(LogTestController::getInstance().contains("HTTP operation timed out, with absolute timeout 3000ms"));
+
+  delete server;

Review comment:
       it was just a temporary check, in no way did I intend it to be the solution, but the cause is: if the handler returns after a server shutdown was initiated it will try to consume the next socket and since that signal will never be notified by the server (as it is waiting for the handlers to shutdown 🤦) we have a deadlock




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org