[GitHub] [incubator-iceberg] danielcweeks commented on a change in pull request #196: Backporting case-sensitivity flag to expression module

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #196: Backporting case-sensitivity flag to expression module
URL: https://github.com/apache/incubator-iceberg/pull/196#discussion_r289494570
 
 

 ##########
 File path: python/iceberg/api/expressions/inclusive_metrics_evaluator.py
 ##########
 @@ -52,13 +53,13 @@ def __init__(self, expr, schema, struct):
         self.struct = struct
 
     def eval(self, file):
-        if file.record_count <= 0:
+        if file.record_count() <= 0:
 
 Review comment:
   Are these changes related to the case sensitivity or just a bug? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org