You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by pwendell <gi...@git.apache.org> on 2014/05/03 22:14:51 UTC

[GitHub] spark pull request: SPARK-1658: Correctly identify if maven is ins...

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/580#discussion_r12257989
  
    --- Diff: make-distribution.sh ---
    @@ -43,12 +43,13 @@
     FWDIR="$(cd `dirname $0`; pwd)"
     DISTDIR="$FWDIR/dist"
     
    -VERSION=$(mvn help:evaluate -Dexpression=project.version | grep -v "INFO" | tail -n 1)
    -if [ $? == -1 ] ;then
    +VERSION_TEXT=$(mvn help:evaluate -Dexpression=project.version 2>/dev/null)
    +if [ $? != 0 ] ;then
    --- End diff --
    
    Do you mind fixing the semi-colon spacing (realize it's not related to your change):
    
    ```
    if [ $? != 0 ]; then
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---