You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/03/12 08:13:12 UTC
Re: Review Request 71966: Cgroups isolator: added support for nested
cgroups during recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71966/#review219914
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 278-280 (patched)
<https://reviews.apache.org/r/71966/#comment308153>
This seems not a proper example since cgroups isolator does not care about freezer hierarchy at all, maybe we should change it to something like:
e.g., the nested cgroups created by the container itself.
- Qian Zhang
On Feb. 12, 2020, 11:47 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71966/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2020, 11:47 p.m.)
>
>
> Review request for mesos, Greg Mann and Qian Zhang.
>
>
> Bugs: MESOS-10079
> https://issues.apache.org/jira/browse/MESOS-10079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables recovery for nested cgroups and implements
> the detection of orphaned nested cgroups.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
>
>
> Diff: https://reviews.apache.org/r/71966/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>