You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/29 21:01:25 UTC

[GitHub] [tvm] altanh opened a new pull request, #11951: [TOPI][x86] support any shape and axis for log softmax

altanh opened a new pull request, #11951:
URL: https://github.com/apache/tvm/pull/11951

   adds support for any shape and axis for `log_softmax` (this was already supported by regular `softmax`)
   
   there's slight code duplication but it was a lot messier when I tried to reuse the `softmax_common` code in-place
   
   cc @shingjan @masahi
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on a diff in pull request #11951: [TOPI][x86] support any shape and axis for log softmax

Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #11951:
URL: https://github.com/apache/tvm/pull/11951#discussion_r910513980


##########
python/tvm/topi/nn/softmax.py:
##########
@@ -136,16 +136,38 @@ def log_softmax(x, axis=-1):
     output : tvm.te.Tensor
         2-D output with same shape

Review Comment:
   @shingjan Can you follow up this in your PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] shingjan commented on a diff in pull request #11951: [TOPI][x86] support any shape and axis for log softmax

Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #11951:
URL: https://github.com/apache/tvm/pull/11951#discussion_r911343679


##########
python/tvm/topi/nn/softmax.py:
##########
@@ -136,16 +136,38 @@ def log_softmax(x, axis=-1):
     output : tvm.te.Tensor
         2-D output with same shape

Review Comment:
   will do! Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] shingjan commented on a diff in pull request #11951: [TOPI][x86] support any shape and axis for log softmax

Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #11951:
URL: https://github.com/apache/tvm/pull/11951#discussion_r911447957


##########
python/tvm/topi/nn/softmax.py:
##########
@@ -136,16 +136,38 @@ def log_softmax(x, axis=-1):
     output : tvm.te.Tensor
         2-D output with same shape

Review Comment:
   @masahi This typo is fixed in #11978



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #11951: [TOPI][x86] support any shape and axis for log softmax

Posted by GitBox <gi...@apache.org>.
masahi merged PR #11951:
URL: https://github.com/apache/tvm/pull/11951


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] shingjan commented on a diff in pull request #11951: [TOPI][x86] support any shape and axis for log softmax

Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #11951:
URL: https://github.com/apache/tvm/pull/11951#discussion_r910469664


##########
python/tvm/topi/nn/softmax.py:
##########
@@ -136,16 +136,38 @@ def log_softmax(x, axis=-1):
     output : tvm.te.Tensor
         2-D output with same shape

Review Comment:
   nit: change this to "N-D" as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org