You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2011/11/18 22:16:31 UTC
Re: Review Request: Add additional lifecycle handlers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/
-----------------------------------------------------------
(Updated 2011-11-18 21:16:31.247556)
Review request for shindig.
Changes
-------
Updated description
Summary (updated)
-------
I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
This addresses bug SHINDIG-1653.
https://issues.apache.org/jira/browse/SHINDIG-1653
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
Diff: https://reviews.apache.org/r/2616/diff
Testing
-------
Modified sample container to log this information and updated unit tests.
Thanks,
Ryan
Re: Review Request: Add additional lifecycle handlers
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3405
-----------------------------------------------------------
Ship it!
I only reviewed the changes to the actions feature. LFTM.
- Matthew
On 2011-11-18 21:56:17, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:56:17)
>
>
> Review request for shindig, Matthew Hatem and Igor Belakovskiy.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add additional lifecycle handlers
Posted by Jesse Ciancetta <jc...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3391
-----------------------------------------------------------
Ship it!
LGTM
- Jesse
On 2011-11-18 21:56:17, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:56:17)
>
>
> Review request for shindig, Matthew Hatem and Igor Belakovskiy.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add additional lifecycle handlers
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3534
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2011-11-18 21:56:17, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:56:17)
>
>
> Review request for shindig, Matthew Hatem and Igor Belakovskiy.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add additional lifecycle handlers
Posted by Igor Belakovskiy <bu...@alum.mit.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3400
-----------------------------------------------------------
Ship it!
LGTM
- Igor
On 2011-11-18 21:56:17, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:56:17)
>
>
> Review request for shindig, Matthew Hatem and Igor Belakovskiy.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add additional lifecycle handlers
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/
-----------------------------------------------------------
(Updated 2011-11-18 21:56:17.267012)
Review request for shindig, Matthew Hatem and Igor Belakovskiy.
Changes
-------
Adding Igor and Matt for their awareness.
Summary
-------
I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
This addresses bug SHINDIG-1653.
https://issues.apache.org/jira/browse/SHINDIG-1653
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
Diff: https://reviews.apache.org/r/2616/diff
Testing
-------
Modified sample container to log this information and updated unit tests.
Thanks,
Ryan
Re: Review Request: Add additional lifecycle handlers
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-11-18 21:51:25, Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, line 556
> > <https://reviews.apache.org/r/2616/diff/4/?file=59402#file59402line556>
> >
> > Do actions not care about the ON_CLOSED event anymore?
ON_CLOSED used to get called before the site was actually closed, so I moved it after we close the site. Now ON_BEFORE_CLOSE gets called before site.close so in order to not regress anything actions and open search should listen for on_before_close. I will add Igor and Matt to the review so they are aware.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3363
-----------------------------------------------------------
On 2011-11-18 21:16:31, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:16:31)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add additional lifecycle handlers
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3363
-----------------------------------------------------------
Ship it!
A few questions, but LGTM.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/2616/#comment7542>
Do actions not care about the ON_CLOSED event anymore?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
<https://reviews.apache.org/r/2616/#comment7543>
Same as actions... do we not care about ON_CLOSED anymore?
- Stanton
On 2011-11-18 21:16:31, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-18 21:16:31)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>