You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/10/14 22:29:46 UTC
Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade:
Upgrade START call cannot find upgrade pack to use (branch-2.1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39306/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 8:29 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Summary (updated)
-----------------
AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use (branch-2.1)
Bugs: AMBARI-13418
https://issues.apache.org/jira/browse/AMBARI-13418
Repository: ambari
Description
-------
Rolling Upgrade and Express Upgrade cannot be started because it cannot find the correct upgrade pack to use based on the type.
The PreChecks endpoint needs to resolve to the same upgrade pack.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java 93093d2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bf7647e
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f0b383c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 066c0e6
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 483a024
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 827348a
Diff: https://reviews.apache.org/r/39306/diff/
Testing
-------
Tested this on Ambari 2.1.3 using branch-2.1 and
1. HDP 2.1 can report a failure during the NON_ROLLING PreCheck if masters are down.
2. HDP 2.1->2.3 can pass the prechecks and start Express Upgrade
3. HDP 2.2 can report a failure during the ROLLING PreCheck if masters are down.
4. HDP 2.2->2.3 can pass the prechecks and start Rolling Upgrade
For the Pre-Checks, tested using these endpoints,
* http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=ROLLING
* http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=NON_ROLLING
I tagged some of the unit tests with Ignore since they were failing in an unrelated area due to the setup.
Thanks,
Alejandro Fernandez
Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade:
Upgrade START call cannot find upgrade pack to use (branch-2.1)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Oct. 14, 2015, 8:38 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java, line 140
> > <https://reviews.apache.org/r/39306/diff/4/?file=1098529#file1098529line140>
> >
> > No need to test, or holdup review, but if someone passes in garbage here it will throw an Exception. Just make sure you see what that looks like from UI when invoking.
Will make this more robust in my next patch. Thanks!
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39306/#review102696
-----------------------------------------------------------
On Oct. 14, 2015, 8:29 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39306/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 8:29 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13418
> https://issues.apache.org/jira/browse/AMBARI-13418
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rolling Upgrade and Express Upgrade cannot be started because it cannot find the correct upgrade pack to use based on the type.
> The PreChecks endpoint needs to resolve to the same upgrade pack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java 93093d2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bf7647e
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f0b383c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 066c0e6
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 483a024
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 827348a
>
> Diff: https://reviews.apache.org/r/39306/diff/
>
>
> Testing
> -------
>
> Tested this on Ambari 2.1.3 using branch-2.1 and
> 1. HDP 2.1 can report a failure during the NON_ROLLING PreCheck if masters are down.
> 2. HDP 2.1->2.3 can pass the prechecks and start Express Upgrade
> 3. HDP 2.2 can report a failure during the ROLLING PreCheck if masters are down.
> 4. HDP 2.2->2.3 can pass the prechecks and start Rolling Upgrade
>
>
> For the Pre-Checks, tested using these endpoints,
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=ROLLING
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=NON_ROLLING
>
>
> I tagged some of the unit tests with Ignore since they were failing in an unrelated area due to the setup.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade:
Upgrade START call cannot find upgrade pack to use (branch-2.1)
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39306/#review102696
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java (line 140)
<https://reviews.apache.org/r/39306/#comment160451>
No need to test, or holdup review, but if someone passes in garbage here it will throw an Exception. Just make sure you see what that looks like from UI when invoking.
- Nate Cole
On Oct. 14, 2015, 4:29 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39306/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 4:29 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13418
> https://issues.apache.org/jira/browse/AMBARI-13418
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rolling Upgrade and Express Upgrade cannot be started because it cannot find the correct upgrade pack to use based on the type.
> The PreChecks endpoint needs to resolve to the same upgrade pack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java 93093d2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bf7647e
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f0b383c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 066c0e6
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 483a024
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 827348a
>
> Diff: https://reviews.apache.org/r/39306/diff/
>
>
> Testing
> -------
>
> Tested this on Ambari 2.1.3 using branch-2.1 and
> 1. HDP 2.1 can report a failure during the NON_ROLLING PreCheck if masters are down.
> 2. HDP 2.1->2.3 can pass the prechecks and start Express Upgrade
> 3. HDP 2.2 can report a failure during the ROLLING PreCheck if masters are down.
> 4. HDP 2.2->2.3 can pass the prechecks and start Rolling Upgrade
>
>
> For the Pre-Checks, tested using these endpoints,
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=ROLLING
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=NON_ROLLING
>
>
> I tagged some of the unit tests with Ignore since they were failing in an unrelated area due to the setup.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade:
Upgrade START call cannot find upgrade pack to use (branch-2.1)
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39306/#review102704
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Oct. 14, 2015, 8:29 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39306/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 8:29 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13418
> https://issues.apache.org/jira/browse/AMBARI-13418
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rolling Upgrade and Express Upgrade cannot be started because it cannot find the correct upgrade pack to use based on the type.
> The PreChecks endpoint needs to resolve to the same upgrade pack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java 93093d2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java bf7647e
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f0b383c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 066c0e6
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 483a024
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 827348a
>
> Diff: https://reviews.apache.org/r/39306/diff/
>
>
> Testing
> -------
>
> Tested this on Ambari 2.1.3 using branch-2.1 and
> 1. HDP 2.1 can report a failure during the NON_ROLLING PreCheck if masters are down.
> 2. HDP 2.1->2.3 can pass the prechecks and start Express Upgrade
> 3. HDP 2.2 can report a failure during the ROLLING PreCheck if masters are down.
> 4. HDP 2.2->2.3 can pass the prechecks and start Rolling Upgrade
>
>
> For the Pre-Checks, tested using these endpoints,
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=ROLLING
> * http://server.:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.3.2.0-2950&UpgradeChecks/upgrade_type=NON_ROLLING
>
>
> I tagged some of the unit tests with Ignore since they were failing in an unrelated area due to the setup.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>