[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released

["Nhat Nguyen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481828#comment-16481828 ] 

Nhat Nguyen commented on LUCENE-8324:
-------------------------------------

[~simonw] Here are steps to reproduce:
 1. Index some docs then flush an uncommitted segment
 2. Make a fully deleted segment: index a doc then delete it
 3. Flush (not commit) the second segment - this segment should be dropped
 4. Commit

I think we should release the dropped segment in either step 3 or step 4.

> Unreferenced files of dropped segments should be released
> ---------------------------------------------------------
>
>                 Key: LUCENE-8324
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8324
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Nhat Nguyen
>            Priority: Major
>         Attachments: release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard deleted are also
> cleaned up right after they are flushed, previously these segments were sticking
> around for a while until they got picked for a merge or received another delete.{quote}
>  
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's flushed, however, its files might be kept around even after a commit. In other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org