[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287253#comment-16287253 ] 

Tsz Wo Nicholas Sze commented on RATIS-124:
-------------------------------------------

Patch looks good.  Some minor comments:
- Let's create the ArrayList right before using it so that it won't be created if it is not needed.
- Please also remove the unused imports.

> RaftLog should be sync'ed on all the entries appended but not the last entry
> ----------------------------------------------------------------------------
>
>                 Key: RATIS-124
>                 URL: https://issues.apache.org/jira/browse/RATIS-124
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Kit Hui
>         Attachments: r124_20171212a.patch
>
>
> In RaftServerImpl.appendEntries, it first appends entries to RaftLog and then calls logSync().  It sync the last entry but not all the entries appended by this call.
> This is a problem if data are written to state machine asynchronously.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)