You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (Jira)" <ji...@apache.org> on 2020/07/13 11:04:00 UTC
[jira] [Commented] (SPARK-32252) Enable doctests in run-tests.py
back
[ https://issues.apache.org/jira/browse/SPARK-32252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156639#comment-17156639 ]
Apache Spark commented on SPARK-32252:
--------------------------------------
User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/29086
> Enable doctests in run-tests.py back
> ------------------------------------
>
> Key: SPARK-32252
> URL: https://issues.apache.org/jira/browse/SPARK-32252
> Project: Spark
> Issue Type: Sub-task
> Components: Project Infra
> Affects Versions: 2.4.6, 3.0.0, 3.1.0
> Reporter: Hyukjin Kwon
> Priority: Major
>
> In run-tests.py script, we're skipping the tests when {{TEST_ONLY_MODULES}} is set. This is mainly because the doctests fail in Github Actions.
> We should test it. Currently it fails as below:
> {code}
> fatal: ambiguous argument 'fc0a1475ef': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> **********************************************************************
> File "./dev/run-tests.py", line 75, in __main__.identify_changed_files_from_git_commits
> Failed example:
> [x.name for x in determine_modules_for_files( identify_changed_files_from_git_commits("fc0a1475ef", target_ref="5da21f07"))]
> Exception raised:
> Traceback (most recent call last):
> File "/usr/lib/python3.6/doctest.py", line 1330, in __run
> compileflags, 1), test.globs)
> File "<doctest __main__.identify_changed_files_from_git_commits[0]>", line 1, in <module>
> [x.name for x in determine_modules_for_files( identify_changed_files_from_git_commits("fc0a1475ef", target_ref="5da21f07"))]
> File "./dev/run-tests.py", line 87, in identify_changed_files_from_git_commits
> universal_newlines=True)
> File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.6/subprocess.py", line 438, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command '['git', 'diff-tree', '--no-commit-id', '--name-only', '-r', 'fc0a1475ef']' returned non-zero exit status 128.
> fatal: ambiguous argument '50a0496a43': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> {code}
> Looks we should fetch the commit to test in GitHub Actions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org