You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/01/26 05:13:29 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4406: Fix flaky windows test
nickva opened a new pull request, #4406:
URL: https://github.com/apache/couchdb/pull/4406
This PR bypasses the socket tests on windows and fixes a flaky chttpd changes tests where we made a too strong of an assumption about the order in which the shards would be returned.
Thanks to @big-r81 for investigating both issues!
See https://github.com/apache/couchdb/pull/4401#issuecomment-1401511199 for his windows test failure report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4406: Fix flaky windows test
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4406:
URL: https://github.com/apache/couchdb/pull/4406#issuecomment-1404963228
Runs through...
See [log](https://paste.apache.org/2b3tr).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4406: Fix flaky windows test
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4406:
URL: https://github.com/apache/couchdb/pull/4406#issuecomment-1405375973
Running
`.\make.cmd eunit apps=chttpd suites=chttpd_socket_buffer_size_test,chttpd_changes_test`
```
Collections
===========
Total Fixture Test Count Failed Errors Skipped
11.9s 10.5s 1.4s 40 0 0 0 EUnit
0.0s 0.0s 0.0s 0 0 0 0 EXUnit
0.0s 0.0s 0.0s 0 0 0 0 JavaScript
0.0s 0.0s 0.0s 0 0 0 0 Mango
Suites
======
Total Fixture Test Count Failed Errors Skipped
11.9s 10.5s 1.4s 38 0 0 0 EUnit - chttpd_changes_test
0.0s 0.0s 0.0s 2 0 0 0 EUnit - chttpd_socket_buffer_size_test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4406: Fix flaky windows test
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #4406:
URL: https://github.com/apache/couchdb/pull/4406#issuecomment-1405420902
> ::in function chttpd_security_tests:create_db/1 (test/eunit/chttpd_security_tests.erl, line 60)
in call from chttpd_security_tests:setup/0 (test/eunit/chttpd_security_tests.erl, line 47)
**error:{badmatch,{error,connection_closed}}
Hmm, that one is unexpected. We just trying to create a db with a PUT and we should expect that to always work:
https://github.com/apache/couchdb/blob/23efd8e5b1aa96ef01640fec03a5fedc945ba8b9/src/chttpd/test/eunit/chttpd_security_tests.erl#L60
With the small buffer socket test, I can see how connection might be closed suddenly or in a different way on Windows but the simple doc PUT in a security test setup points to something else going on.
Could we be running out of sockets? Not sure descriptor limit a thing on Windows?. Try running just that one security test separately, wonder if that would fail.
Another idea is that there is a genuine race or bug somewhere in couch/ibrowse/mochiweb/erlang vm code that is exposed on Windows only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4406: Fix flaky windows test
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4406:
URL: https://github.com/apache/couchdb/pull/4406#issuecomment-1405394166
Would add one additional fixture setup failure...
```
fixture setup [39,1,1,6]
------------------------
::in function chttpd_security_tests:create_db/1 (test/eunit/chttpd_security_tests.erl, line 60)
in call from chttpd_security_tests:setup/0 (test/eunit/chttpd_security_tests.erl, line 47)
**error:{badmatch,{error,connection_closed}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky windows test [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4406:
URL: https://github.com/apache/couchdb/pull/4406#issuecomment-1777990429
Adding some other flaky tests:
```
module 'smoosh_persist'
smoosh_persist:151: persist_unpersist_test_ (t_write_read_delete)...[0.015 s] ok
smoosh_persist:152: persist_unpersist_test_ (t_fail_write_read_delete)...[0.001 s] ok
smoosh_persist:153: persist_unpersist_test_ (t_corrupted_read)...[0.031 s] ok
smoosh_persist:154: persist_unpersist_test_ (t_check_setup)...*failed*
in function smoosh_persist:t_check_setup/1 (src/smoosh_persist.erl, line 210)
in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
in call from eunit_proc:run_group/2 (eunit_proc.erl, line 570)
**error:{assertEqual,[{module,smoosh_persist},
{line,210},
{expression,"check_setup ( )"},
{expected,{error,{"write",eacces}}},
{value,ok}]}
output:<<"">>
smoosh_persist:155: persist_unpersist_test_ (t_persist_unpersist_disabled)...ok
smoosh_persist:156: persist_unpersist_test_ (t_persist_unpersist_enabled)...[0.018 s] ok
smoosh_persist:157: persist_unpersist_test_ (t_persist_unpersist_errors)...*failed*
in function smoosh_persist:t_persist_unpersist_errors/1 (src/smoosh_persist.erl, line 277)
in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
in call from eunit_proc:run_group/2 (eunit_proc.erl, line 570)
**error:{assertEqual,[{module,smoosh_persist},
{line,277},
{expression,"persist ( Q1 , # { } , # { } )"},
{expected,{error,eacces}},
{value,ok}]}
output:<<"">>
[done in 1.579 s]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org