You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/09/07 09:10:21 UTC
[GitHub] [cordova-docs] timbru31 commented on a change in pull request #1063: Draft: Team page
timbru31 commented on a change in pull request #1063:
URL: https://github.com/apache/cordova-docs/pull/1063#discussion_r484298050
##########
File path: www/contribute/team.html
##########
@@ -0,0 +1,41 @@
+---
+layout: team
+title: Team
+---
+
+<!-- REMOVE THIS LINK BEFORE PUBLISHING. This is just for IntelliSense while coding -->
+<!-- <link rel="stylesheet" type="text/css" href="static/css/lib/bootstrap.css"/> -->
+
+<div class="row">
+ <div class="col-sm-12 text-center">
+ <h1>Team</h1>
+ <p>These are some of people behind Apache Cordova</p>
+ </div>
+</div>
+
+{% for member in site.members %}
+<div class="row">
+ <div class="col-sm-8 col-xs-8">
+ <span>
+ <h2>{{ member.name }}</h2>
+ <p>{{ member.subtitle }}</p>
+ </span>
+ </div>
+</div>
+<div class="row">
+ <div class="col-sm-8">
+ <p>
+ {{ member.content }}
+ </p>
+ </div>
+ <div class="col-sm-3 col-sm-offset-1">
+ <img src="{{ member.imageurl }}"><img>
+ {% if member.twitter %}
+ <a href="{{ member.twitter }}">Twitter</a>
+ {% endif %}
+ {% if member.homepage %}
+ <a href="{{ member.homepage }}">Homepage</a>
+ {% endif %}
+ </div>
+</div>
+{% endfor %}
Review comment:
```suggestion
{% endfor %}
```
##########
File path: www/_layouts/team.html
##########
@@ -0,0 +1,8 @@
+---
+layout: page
+team_tab: true
+---
+
+<div class="contribute-help">
Review comment:
Mandatory to use this class? Does not seem fitting for the team page.
##########
File path: www/contribute/team.html
##########
@@ -0,0 +1,41 @@
+---
+layout: team
+title: Team
+---
+
+<!-- REMOVE THIS LINK BEFORE PUBLISHING. This is just for IntelliSense while coding -->
Review comment:
Should we remove this link? ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org