[jira] [Comment Edited] (OFBIZ-7950) Improve consistency of service createEmployee

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614727#comment-15614727 ] 

Jacques Le Roux edited comment on OFBIZ-7950 at 10/28/16 9:24 AM:
------------------------------------------------------------------

Hi Paul,

In Florian's patch, like for 1st and last name, no address field is enforced. It's only when the 1st or last name is missing then it's considered a mistake (ie if you provide only one of the fields it's a mistake, you need to provide both). So I guess Florian was not clear when he wrote "Same way for the address" or he did not implement it finally (ie no address field is enforced, but if address1 is provided then it's automatically a PRIMARY_LOCATION).


was (Author: jacques.le.roux):
Hi Paul,

In Florian's patch, like for 1st and last name, no address field is enforced. It's only when the 1st or last name is missing then it's considered a mistake (ie if you provide only one of the field it's a mistake, you need to provide both). So I guess Florian was not clear when he used "Same way for the address" or he did not implement it finally (ie no address field is enforced, but if address1 is provided then it's automatically a PRIMARY_LOCATION.

> Improve consistency of service createEmployee
> ---------------------------------------------
>
>                 Key: OFBIZ-7950
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7950
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: humanres
>    Affects Versions: Trunk
>            Reporter: Montalbano Florian
>            Assignee: Nicolas Malin
>            Priority: Minor
>              Labels: consistency, create, employee, service
>         Attachments: OFBIZ-7950_proposition.patch
>
>
> In the humanres component, we can create an employee through the form https://localhost:8443/humanres/control/NewEmployee .
> This form has required fields that are not the same requirement than the service called when submitting the form.
> The service called is createEmployee.
> In the service, everything is declared optional but the postalAddContactMechPurpTypeId (which is set in the form as an hidden field).
> This means we could create an Employee without forcing a telephone number or a primary address or even a first name.
> But then, within the service, a check is done on the firstName and lastName parameters and if missing, an error shows up.
> We could harmonize things a little.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)