You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/07/10 13:57:05 UTC
[GitHub] tajo pull request: TAJO-934: Multiple DISTINCT returns null groupi...
GitHub user babokim opened a pull request:
https://github.com/apache/tajo/pull/63
TAJO-934: Multiple DISTINCT returns null grouping key value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/babokim/tajo TAJO-934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 542fe82ed4ed1dc2764833ca81c0dc334b1e2c1c
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-10T11:52:23Z
TAJO-934: Multiple DISTINCT returns null grouping key value.
commit ff1a5c7c503b569348bcd9b3fba5a196ead517ed
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-10T11:55:52Z
TAJO-934: Multiple DISTINCT returns null grouping key value.
Remove debug comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-934: Multiple DISTINCT returns null groupi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/63#issuecomment-48700667
+1
The travis test result is failed due to 'No output' in the last 10 minutes. But, I manually verified 'mvn clean install'. The latest bug fix also looks nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-934: Multiple DISTINCT returns null groupi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-934: Multiple DISTINCT returns null groupi...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/63#issuecomment-48693574
hyunsik please wait a while. I find another bug about multiple distinct.
The following query is recognized as a general group by query not a distinct group by query.
select count(distinct col1) + count(distinct col2) from table1
I'll fix this bug in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-934: Multiple DISTINCT returns null groupi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/63#issuecomment-48693318
+1
LGTM! I've changed some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---