You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2023/12/25 11:42:18 UTC
[PR] Fix `GET` return no error when key type is not string [kvrocks]
jihuayu opened a new pull request, #1970:
URL: https://github.com/apache/kvrocks/pull/1970
fixed #1969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1868958725
@jihuayu Could you add a test case to make sure this issue was resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1868960464
@git-hulk No problem, I will add test cases for each type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1868945771
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1970) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1970&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1970&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1970&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1970)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1869875145
@jihuayu This bug should be resolved after https://github.com/apache/kvrocks/pull/1971, but can add test cases to make sure it works well if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1868967334
> @git-hulk No problem, I will add test cases for each type.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu closed pull request #1970: Fix `GET` return no error when key type is not string
URL: https://github.com/apache/kvrocks/pull/1970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1869876272
@git-hulk All right, I'm a bit busy these days, I will come back later to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `GET` return no error when key type is not string [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #1970:
URL: https://github.com/apache/kvrocks/pull/1970#issuecomment-1873662329
Many commands have this kind of constraint (cannot operate on keys of other types), and we may need a universal method to test them.
I will find a better way that covers this issue.
Close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org