You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/31 10:29:30 UTC
[GitHub] [james-project] jeantil commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
jeantil commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642384313
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
```suggestion
<image>gcr.io/distroless/java:11</image>
```
along with https://martinheinz.dev/blog/49 for debugging ?
applies to all pom.xml which use jib :D
##########
File path: server/container/guice/jpa-smtp/src/main/extensions-jars/README.md
##########
@@ -2,4 +2,4 @@
The jar in this folder will be added to JAMES classpath when mounted under /root/extensions-jars inside the running container.
-You can use it to add your customs Mailets/Matchers.
+You can use it to add you customs Mailets/Matchers.
Review comment:
```suggestion
You can use it to add your custom Mailets/Matchers.
```
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
Review comment:
```suggestion
<id>install-glowroot</id>
```
for all pom.xml in this PR :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org