[jira] Commented: (WICKET-2393) Passwords should not be trimmed

["Philippe Laflamme (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785958#action_12785958 ] 

Philippe Laflamme commented on WICKET-2393:
-------------------------------------------

Why not base the decision on other password entry systems?

Here's the behaviour of some sites/systems:
* JIRA: does not trim
* Google: trims
* Drupal: trims
* sshd: does not trim
* GDM: does not trim
* Hotmail: does not trim
* Windows: does not trim

If the password was created using the same behaviour, all this discussion is moot, because no one will ever notice whether their password is being trimmed or not...

My suggestion: offer a method for setting the desired behaviour and keep the current trimming behaviour as default.

> Passwords should not be trimmed
> -------------------------------
>
>                 Key: WICKET-2393
>                 URL: https://issues.apache.org/jira/browse/WICKET-2393
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.0
>            Reporter: Olivier Ribardière
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.4.2
>
>         Attachments: WICKET-2393-fix.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.