You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/11 22:53:46 UTC

[jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Also includes cleanup pass 1 on javadoc removal. Ex. removes javadoc that is generated or obvious.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs adrian.dedupe-vcloud

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs/pull/91

-- Commit Summary --

  * Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs. cleanup pass on javadoc.

-- File Changes --

    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorContext.java (16)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/admin/VCloudDirectorAdminApi.java (8)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/AbstractVApp.java (31)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/AccessSetting.java (8)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/AdminCatalog.java (10)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/AdminVdc.java (23)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Capabilities.java (18)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Capacity.java (44)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/CapacityWithUsage.java (32)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Catalog.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/CatalogItem.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/ComputeCapacity.java (21)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Entity.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Error.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/File.java (18)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Group.java (15)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Link.java (9)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Media.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Metadata.java (8)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/MetadataEntry.java (7)
    D vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/MetadataValue.java (25)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Owner.java (8)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/ProductSectionList.java (16)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Property.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/RasdItemsList.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Reference.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/References.java (22)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Resource.java (9)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/ResourceEntity.java (5)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/RoleReferences.java (17)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/ScreenTicket.java (9)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/SessionWithToken.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Task.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/TasksList.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/User.java (38)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VApp.java (41)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VAppChildren.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VAppTemplate.java (27)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Vdc.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Vm.java (8)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VmPendingQuestion.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VmQuestionAnswer.java (15)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/VmQuestionAnswerChoice.java (13)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/DhcpService.java (28)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/ExternalNetwork.java (17)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/FirewallRule.java (45)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/FirewallRuleProtocols.java (22)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/FirewallService.java (29)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpAddresses.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpRanges.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnLocalPeer.java (28)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnManagedPeer.java (12)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnPeer.java (2)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnRemotePeer.java (29)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnService.java (30)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnThirdPartyPeer.java (21)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnTunnel.java (42)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/IpsecVpnUnmanagedPeer.java (2)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatOneToOneBasicRule.java (20)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatOneToOneVmRule.java (21)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatPortForwardingRule.java (22)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatRule.java (27)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatService.java (29)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NatVmRule.java (23)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NetworkAssignment.java (17)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NetworkConfiguration.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NetworkConnection.java (23)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NetworkFeatures.java (16)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/NetworkService.java (19)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/RouterInfo.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/SmtpServerSettings.java (16)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/StaticRoute.java (19)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/StaticRoutingService.java (28)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/VAppNetwork.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/network/VAppNetworkConfiguration.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/AdminOrg.java (20)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/CustomOrgLdapSettings.java (26)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/Org.java (6)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgEmailSettings.java (22)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgGeneralSettings.java (20)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgLdapGroupAttributes.java (18)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgLdapUserAttributes.java (22)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgLeaseSettings.java (15)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgList.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgPasswordPolicySettings.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgSettings.java (18)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/org/OrgVAppTemplateLeaseSettings.java (16)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/CaptureVAppParams.java (14)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/CloneMediaParams.java (19)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/CloneVAppParams.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/CloneVAppTemplateParams.java (14)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/ComposeVAppParams.java (28)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/ControlAccessParams.java (9)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/DeployVAppParams.java (6)
    D vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/InstantiateOvfParams.java (146)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/InstantiateVAppParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/InstantiateVAppTemplateParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/InstantiationParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/MediaInsertOrEjectParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/ParamsType.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/PublishCatalogParams.java (18)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/RecomposeVAppParams.java (17)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/RelocateParams.java (21)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/SourcedCompositionItemParam.java (26)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/UndeployVAppParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/UploadVAppTemplateParams.java (9)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/params/VAppCreationParams.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/CatalogReferences.java (7)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/Container.java (26)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryList.java (8)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultAdminGroupRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultAdminUserRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultAdminVdcRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultCatalogRecord.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultDatastoreRecord.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultMediaRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultNetworkRecord.java (11)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultRecord.java (35)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultRecords.java (21)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultReferences.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultRightRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultRoleRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultStrandedUserRecord.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultVAppRecord.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultVAppTemplateRecord.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultVMRecord.java (11)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/VAppReferences.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/CustomizationSection.java (20)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/GuestCustomizationSection.java (33)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/LeaseSettingsSection.java (23)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/NetworkConfigSection.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/NetworkConnectionSection.java (4)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/OperatingSystemSection.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/RuntimeInfoSection.java (7)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/VirtualHardwareSection.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/Catalog.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/Network.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/Org.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/OrgList.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/TasksList.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/VCloudLogin.java (5)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/endpoints/Vdc.java (3)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/CatalogApi.java (95)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/MediaApi.java (53)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/MetadataApi.java (37)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/NetworkApi.java (15)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/OrgApi.java (28)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/QueryApi.java (38)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/TaskApi.java (31)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/VAppApi.java (535)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/VAppTemplateApi.java (301)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/VdcApi.java (172)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/VmApi.java (679)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminCatalogApi.java (156)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminNetworkApi.java (59)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminOrgApi.java (274)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminVdcApi.java (41)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/GroupApi.java (74)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/features/admin/UserApi.java (89)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/functions/IdToAdminHref.java (9)
    R vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/functions/IdToHref.java (12)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/functions/SectionForVApp.java (6)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/internal/VCloudDirectorContextImpl.java (25)
    M vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/user/VCloudDirectorApi.java (7)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/AbstractVAppApiLiveTest.java (103)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/domain/Checks.java (24)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/CatalogApiExpectTest.java (86)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/CatalogApiLiveTest.java (59)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/KeyPairsApiLiveTest.java (13)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/MediaApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/MediaApiLiveTest.java (72)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/MetadataApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/NetworkApiExpectTest.java (36)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/NetworkApiLiveTest.java (15)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/OrgApiExpectTest.java (35)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/OrgApiLiveTest.java (29)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/QueryApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/QueryApiLiveTest.java (13)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/TaskApiExpectTest.java (11)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/TaskApiLiveTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/UploadApiLiveTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VAppApiExpectTest.java (22)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VAppApiLiveTest.java (199)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VAppNetworksLiveTest.java (37)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VAppTemplateApiExpectTest.java (7)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VAppTemplateApiLiveTest.java (79)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VdcApiExpectTest.java (9)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VdcApiLiveTest.java (31)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VmApiExpectTest.java (21)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/VmApiLiveTest.java (248)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminCatalogApiExpectTest.java (104)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminCatalogApiLiveTest.java (41)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminNetworkApiExpectTest.java (51)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminNetworkApiLiveTest.java (19)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminOrgApiExpectTest.java (4)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminOrgApiLiveTest.java (43)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminQueryApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminQueryApiLiveTest.java (20)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminVdcApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/AdminVdcApiLiveTest.java (21)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/GroupApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/GroupApiLiveTest.java (15)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/UserApiExpectTest.java (85)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/admin/UserApiLiveTest.java (13)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/systemadmin/SystemAdminVAppApiExpectTest.java (3)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/systemadmin/SystemAdminVAppApiLiveTest.java (25)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/systemadmin/SystemAdminVmApiExpectTest.java (6)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/features/systemadmin/SystemAdminVmApiLiveTest.java (32)
    M vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/internal/BaseVCloudDirectorApiLiveTest.java (113)
    D vcloud-director/src/test/resources/vapp/vAppEntity.xml (4)
    D vcloud-director/src/test/resources/vm/vmEntity.xml (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/91.patch
https://github.com/jclouds/jclouds-labs/pull/91.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by Adrian Cole <no...@github.com>.
Closed #91.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#event-177337394

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by Adrian Cole <no...@github.com>.
cherry-picked into master. can follow-up on 1.8.x after 1.8.1 is out.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58772474

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #312](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/312/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58764934

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by Andrew Phillips <no...@github.com>.
+1 to this - many thanks for the cleanup!

Regarding the removal of the string-param variants of all the API calls: would love to have this as it definitely improves maintainability. Since we're in labs, fine with merging this now, but I would be interested to hear _why_ we had all the string methods in the first place and if any users are really dependent on them.

I guess we'll see that after the commit goes in ;-)

Also, given the discussion on the dev thread, would it make sense to merge this but then wait before continuing to sink any additional time into this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58770717

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by Adrian Cole <no...@github.com>.
Yeah, this is the last cleanup on vcloud-director for me before a
heart-to-heart on it. thx.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58772438

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by Adrian Cole <no...@github.com>.
@andreaturli @ccustine @nacx

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58764186

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1677](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1677/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58764643

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #311](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/311/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58764367

Re: [jclouds-labs] Dedupe vcloud api calls and instead expose helper to resolve ids to hrefs (#91)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1678](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1678/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/91#issuecomment-58765195