You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/05 03:10:41 UTC

[GitHub] [beam] reuvenlax commented on a diff in pull request #17359: [BEAM-14303] Add a way to exclude output timestamp watermark holds

reuvenlax commented on code in PR #17359:
URL: https://github.com/apache/beam/pull/17359#discussion_r865527548


##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -1216,6 +1219,14 @@ private Instant minTargetAndGcTime(Instant target) {
     @Override
     public Timer withOutputTimestamp(Instant outputTimestamp) {
       this.outputTimestamp = outputTimestamp;
+      this.noOutputTimestamp = false;
+      return this;
+    }
+
+    @Override
+    public Timer withNoOutputTimestamp() {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org