[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #624: Update SparkTableUtil to use SessionCatalog and proper MetricsConfig

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #624: Update SparkTableUtil to use SessionCatalog and proper MetricsConfig
URL: https://github.com/apache/incubator-iceberg/pull/624#discussion_r344231138
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/MetricsModes.java
 ##########
 @@ -144,4 +146,22 @@ public String toString() {
       return "full";
     }
   }
+
+  private abstract static class ProxySerializableMetricsMode implements MetricsMode {
 
 Review comment:
   We use a similar approach in `PrimitiveType`. If we serialize `MetricsMode` directly, it will be deserialized back on executors and we will have a problem that `MetricsMode.None.get()` is never equal to our deserialized value even though it was `none` before as use `==` for equality checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org