[jira] [Commented] (BOOKKEEPER-697) stats collection on bookkeeper server

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077517#comment-14077517 ] 

Flavio Junqueira commented on BOOKKEEPER-697:
---------------------------------------------

The patch looks good, I just have a couple of comments:

# I'm not sure what's going on with the use of NullStatsLogger in some constructors. That means that we won't be collecting stats for those classes, no? What am I missing?
# I've tried to run the tests a number of times and it fails for me every time, but a different test case. It doesn't like this patch is causing it, so the tests might be a bit unstable with the recent changes. Are you observing the same?

> stats collection on bookkeeper server
> -------------------------------------
>
>                 Key: BOOKKEEPER-697
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-697
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Aniruddha
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-697.patch
>
>
> Stats collection on bookkeeper server.



--
This message was sent by Atlassian JIRA
(v6.2#6252)