You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2012/06/18 23:08:42 UTC
[jira] [Created] (LUCENE-4155) Move & hide ReaderSlice and BitSlice
classes (and possibly others) to oal.index package; move ReaderUtil to
oal.index
Uwe Schindler created LUCENE-4155:
-------------------------------------
Summary: Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
Key: LUCENE-4155
URL: https://issues.apache.org/jira/browse/LUCENE-4155
Project: Lucene - Java
Issue Type: Bug
Components: core/index
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 4.0, 5.0
Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399399#comment-13399399 ]
Michael McCandless commented on LUCENE-4155:
--------------------------------------------
+1, thanks Uwe!
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398489#comment-13398489 ]
Uwe Schindler commented on LUCENE-4155:
---------------------------------------
I marked those classes as @lucene.internal, this was missing before.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398503#comment-13398503 ]
Uwe Schindler commented on LUCENE-4155:
---------------------------------------
More: DummyConcurrentLock is dead and should be removed. It was only there to implement MultiSearcher and ParallelMultiSearcher using same code.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4155) Move & hide ReaderSlice and BitSlice
classes (and possibly others) to oal.index package; move ReaderUtil to
oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4155:
----------------------------------
Attachment: LUCENE-4155.patch
New patch. This one also moves the very custom "MultiBits" class and makes it private. This one should never be public, especially as it exports some very "IndexReader" special features. It is no longer of general use.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4155) Move & hide ReaderSlice and BitSlice
classes (and possibly others) to oal.index package; move ReaderUtil to
oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4155:
----------------------------------
Attachment: LUCENE-4155.patch
Path that moves those 3 classes to index package. Unfortunately, I was only able to make BitsSlice pkg-private (only used by MultiDocsEnum,...), ReaderSlice must be public, as used by Codecs.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-4155.
-----------------------------------
Resolution: Fixed
Committed trunk revision: 1352942, 1352949
Backported 4.x revision: 1352956
I hope all compiles and tests on Jenkins!
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398501#comment-13398501 ]
Uwe Schindler commented on LUCENE-4155:
---------------------------------------
Doning more review: Why is CodecUtil in util package? Just because it ends in *Util? In my opinion, it should be in codec package.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4155) Move & hide ReaderSlice and
BitSlice classes (and possibly others) to oal.index package; move
ReaderUtil to oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398504#comment-13398504 ]
Uwe Schindler commented on LUCENE-4155:
---------------------------------------
TwoPhaseCommit(Tool) should also be in index package.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4155) Move & hide ReaderSlice and BitSlice
classes (and possibly others) to oal.index package; move ReaderUtil to
oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4155:
----------------------------------
Issue Type: Task (was: Bug)
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4155) Move & hide ReaderSlice and BitSlice
classes (and possibly others) to oal.index package; move ReaderUtil to
oal.index
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4155:
----------------------------------
Attachment: LUCENE-4155.patch
New patch with moving renaming more classes to appropinquate packages:
- CodecUtils to codecs package
- TwoPhaseCommit* and TermContext to index package
I will commit this later today, as patch might get outdated soon.
> Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4155
> URL: https://issues.apache.org/jira/browse/LUCENE-4155
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4155.patch, LUCENE-4155.patch, LUCENE-4155.patch
>
>
> Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.
> ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org